Source: briquolo Version: 0.5.7-8 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: buildpath X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi, Whilst working on the Reproducible Builds effort [0] we noticed that briquolo could not be built reproducibly. This is because it embeds he absolute build path as a fallback directory to find data files during the development cycle. A patch is attached that strips these out of the Debian build. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
--- a/debian/patches/0005-Reproducible-build.patch 1970-01-01 01:00:00.000000000 +0100 --- b/debian/patches/0005-Reproducible-build.patch 2020-05-12 09:11:55.878141297 +0100 @@ -0,0 +1,33 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2020-05-12 + +--- briquolo-0.5.7.orig/src/MOGL/MOGL_Constante.cpp ++++ briquolo-0.5.7/src/MOGL/MOGL_Constante.cpp +@@ -48,10 +48,6 @@ void MOGL_Constante::_InitialiserVariabl + { + _DataDir=DATADIR_BRIQUOLO"/data"; + } +- else +- { +- _DataDir=SRCTOPDIR"/data/data"; +- } + #endif + } + +--- briquolo-0.5.7.orig/src/Constante.cpp ++++ briquolo-0.5.7/src/Constante.cpp +@@ -120,13 +120,6 @@ void Constante::_InitialiserVariables() + _Global=DATADIR_BRIQUOLO; + _DirLocale=LOCALEDIR; + } +- else +- { +- // Le fichier témoin n'existe pas, cela signifie que l'on n'a pas fait le make install +- // On doit prendre les fichier de données dans le rep des sources +- _Global=SRCTOPDIR"/data"; +- _DirLocale=SRCTOPDIR"/po"; +- } + _Data="/data"; + _Tableau="/tableau"; + --- a/debian/patches/series 2020-05-12 08:54:38.094462848 +0100 --- b/debian/patches/series 2020-05-12 09:04:19.406774295 +0100 @@ -2,3 +2,4 @@ 0002-gcc-4.3-fixes.patch 0003-fix-ati-crash.patch 0004-Fix-FTBFS-with-libpng-1.5.patch +0005-Reproducible-build.patch