Bug#959876: fakeroot: fstatat fails if pathname is empty

[Norbert Lange]

Package: fakeroot
Version: 1.24-1
Severity: important
Tags: patch

Hello,

testing a yet-to-be released version of systemd-tmpfiles under fakeroot.

fakeroot is masking out flags like AT_EMPTY_PATH which would be necessary,
so the calls will fail.


systemd PR: https://github.com/systemd/systemd/pull/15718


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages fakeroot depends on:
ii  libc6        2.30-4
ii  libfakeroot  1.24-1

fakeroot recommends no packages.

fakeroot suggests no packages.

-- no debconf information

--- a/libfakeroot.c
+++ b/libfakeroot.c
@@ -886,7 +886,7 @@
   /* If AT_SYMLINK_NOFOLLOW is set in the fchownat call it should
      be when we stat it. */
   INT_STRUCT_STAT st;
-  r=INT_NEXT_FSTATAT(dir_fd, path, &st, (flags & AT_SYMLINK_NOFOLLOW));
+  r=INT_NEXT_FSTATAT(dir_fd, path, &st, (flags & (AT_SYMLINK_NOFOLLOW | 
AT_EMPTY_PATH | AT_NO_AUTOMOUNT)));
 
   if(r)
     return(r);
@@ -1023,7 +1023,7 @@
 
   /* If AT_SYMLINK_NOFOLLOW is set in the fchownat call it should
      be when we stat it. */
-  r=INT_NEXT_FSTATAT(dir_fd, path, &st, flags & AT_SYMLINK_NOFOLLOW);
+  r=INT_NEXT_FSTATAT(dir_fd, path, &st, flags & (AT_SYMLINK_NOFOLLOW | 
AT_EMPTY_PATH | AT_NO_AUTOMOUNT));
 
   if(r)
     return(r);