Package: git-buildpackage
Version: 0.9.19
Severity: wishlist

Hi,

my OCD is telling me that a changelog should be properly formatted, with
full stops and all.

Please consider changing the default from "New upstream version X" to
"New upstream version X.".
Attached an untested patch to do so.

TIA!

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
diff -Nru git-buildpackage-0.9.19/gbp/config.py 
git-buildpackage-0.9.19+nmu1/gbp/config.py
--- git-buildpackage-0.9.19/gbp/config.py       2020-02-28 09:48:01.000000000 
+0100
+++ git-buildpackage-0.9.19+nmu1/gbp/config.py  2020-05-03 16:48:56.000000000 
+0200
@@ -137,7 +137,7 @@
                 'ignore-branch': 'False',
                 'ignore-new': 'False',
                 'ignore-regex': '',
-                'import-msg': 'New upstream version %(version)s',
+                'import-msg': 'New upstream version %(version)s.',
                 'interactive': 'True',
                 'keyid': '',
                 'merge': 'True',
diff -Nru git-buildpackage-0.9.19/gbp.conf git-buildpackage-0.9.19+nmu1/gbp.conf
--- git-buildpackage-0.9.19/gbp.conf    2019-10-26 10:24:20.000000000 +0200
+++ git-buildpackage-0.9.19+nmu1/gbp.conf       2020-05-03 16:49:07.000000000 
+0200
@@ -71,7 +71,7 @@
 # emulate old behaviour of calling dch:
 #postimport = dch -v%(version)s New Upstream Version
 # commit message:
-#import-msg = New upstream version %(version)s
+#import-msg = New upstream version %(version)s.
 
 # Options only affecting gbp import-dsc
 [import-dsc]
diff -Nru git-buildpackage-0.9.19/nosetests.xml 
git-buildpackage-0.9.19+nmu1/nosetests.xml
--- git-buildpackage-0.9.19/nosetests.xml       2020-02-28 09:06:02.000000000 
+0100
+++ git-buildpackage-0.9.19+nmu1/nosetests.xml  2020-05-03 16:49:25.000000000 
+0200
@@ -1526,7 +1526,7 @@
     --import-msg=IMPORT_MSG
                         Format string for commit message used to commit the
                         upstream tarball, default is 'New upstream version
-                        %(version)s'
+                        %(version)s.'
     --symlink-orig      Whether to create a symlink from the upstream tarball
                         to the orig.tar.gz if needed, default is 'True'
     --no-symlink-orig   negates '--symlink-orig'
@@ -1594,7 +1594,7 @@
     --import-msg=IMPORT_MSG
                         Format string for commit message used to commit the
                         upstream tarball, default is 'New upstream version
-                        %(version)s'
+                        %(version)s.'
 
   version and branch naming options:
     version number and branch layout options

Attachment: signature.asc
Description: PGP signature

Reply via email to