Package: ros-ros-comm Version: 1.14.3+ds1-11 Severity: wishlist Tags: patch User: [email protected] Usertags: boost1.71
Dear Maintainer, your package fails to build with boost1.71. You can find a build log attached. If you want to attempt the build yourself, an updated version of boost-defaults which brings in boost1.71 dependencies can be found adding this line to your sources.list file: deb https://people.debian.org/~gio/reprepro gio main This bug has severity whishlist for the moment, but it will raised to RC as soon as version 1.71 of Boost is promoted to default. More specifically, your package fails building because it depends on package libboost-signals-dev, which does not exist any more. The attached patch should fix the bug. Thanks and all the best, Giovanni. -- Giovanni Mascellani <[email protected]> Postdoc researcher - Université Libre de Bruxelles
From 073810177ac6dec06f9d2967e705e4016e7cca7f Mon Sep 17 00:00:00 2001 From: Giovanni Mascellani <[email protected]> Date: Sun, 22 Mar 2020 11:23:16 +0100 Subject: [PATCH] Fix FTBFS with Boost 1.71. --- debian/changelog | 7 +++ debian/control | 6 +-- ...09-Do-not-use-Boost.Signals-any-more.patch | 50 +++++++++++++++++++ debian/patches/series | 1 + 4 files changed, 61 insertions(+), 3 deletions(-) create mode 100644 debian/patches/0009-Do-not-use-Boost.Signals-any-more.patch diff --git a/debian/changelog b/debian/changelog index e2f9e67..6da802f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +ros-ros-comm (1.14.3+ds1-11.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Do not depend on libboost-signals-dev, which does not exist any more. + + -- Giovanni Mascellani <[email protected]> Sun, 22 Mar 2020 11:23:01 +0100 + ros-ros-comm (1.14.3+ds1-11) unstable; urgency=medium * Add https://github.com/ros/ros_comm/pull/1741 (Fix CVE-2019-13445) diff --git a/debian/control b/debian/control index 7ffe5be..e31ee90 100644 --- a/debian/control +++ b/debian/control @@ -8,7 +8,7 @@ Priority: optional Build-Depends: debhelper-compat (= 12), catkin (>= 0.7.14-5), dh-exec, libroscpp-core-dev, python3-rosunit, libconsole-bridge-dev, libboost-date-time-dev, libboost-filesystem-dev, libboost-program-options-dev, libboost-regex-dev, - libboost-system-dev, libboost-thread-dev, libboost-signals-dev, liblz4-dev, + libboost-system-dev, libboost-thread-dev, liblz4-dev, ros-message-generation, libbz2-dev, libros-rosgraph-msgs-dev, libstd-msgs-dev, dh-python, python3-dev, liblog4cxx-dev, libstd-srvs-dev, libboost-chrono-dev, libb64-dev, librosconsole-dev, pluginlib-dev, libgpgme-dev, python3-empy Standards-Version: 4.4.1 @@ -26,7 +26,7 @@ Package: libroscpp-dev Section: libdevel Architecture: any Multi-Arch: same -Depends: libroscpp2d (= ${binary:Version}), ${misc:Depends}, python3, libboost-signals-dev, libboost-filesystem-dev, libboost-system-dev, librosconsole-dev, libros-rosgraph-msgs-dev, libxmlrpcpp-dev, libroscpp-msg-dev +Depends: libroscpp2d (= ${binary:Version}), ${misc:Depends}, python3, libboost-filesystem-dev, libboost-system-dev, librosconsole-dev, libros-rosgraph-msgs-dev, libxmlrpcpp-dev, libroscpp-msg-dev Description: Robot OS development files for libroscpp This package is part of Robot OS (ROS). roscpp is a C++ implementation of ROS. It provides a client library that enables C++ @@ -467,7 +467,7 @@ Package: libmessage-filters-dev Section: libdevel Architecture: any Multi-Arch: same -Depends: libmessage-filters1d (= ${binary:Version}), ${misc:Depends}, libroscpp-dev, libboost-signals-dev, libboost-thread-dev +Depends: libmessage-filters1d (= ${binary:Version}), ${misc:Depends}, libroscpp-dev, libboost-thread-dev Description: Development files for Robot OS message-filters This package is part of Robot OS (ROS). It contains the development files for libmessage-filters, which implements a set of message diff --git a/debian/patches/0009-Do-not-use-Boost.Signals-any-more.patch b/debian/patches/0009-Do-not-use-Boost.Signals-any-more.patch new file mode 100644 index 0000000..663abc4 --- /dev/null +++ b/debian/patches/0009-Do-not-use-Boost.Signals-any-more.patch @@ -0,0 +1,50 @@ +From: Giovanni Mascellani <[email protected]> +Date: Sun, 22 Mar 2020 11:25:41 +0100 +Subject: Do not use Boost.Signals any more. + +Boost.Signals was replaced by Boost.Signals2, which is header-only. +--- + clients/roscpp/CMakeLists.txt | 2 +- + test/test_roscpp/CMakeLists.txt | 2 +- + utilities/message_filters/CMakeLists.txt | 2 +- + 3 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/clients/roscpp/CMakeLists.txt b/clients/roscpp/CMakeLists.txt +index 4fb5dc3..faaa4aa 100644 +--- a/clients/roscpp/CMakeLists.txt ++++ b/clients/roscpp/CMakeLists.txt +@@ -22,7 +22,7 @@ list(GET roscpp_VERSION_LIST 2 roscpp_VERSION_PATCH) + + configure_file(${CMAKE_CURRENT_SOURCE_DIR}/include/ros/common.h.in ${CATKIN_DEVEL_PREFIX}/${CATKIN_GLOBAL_INCLUDE_DESTINATION}/ros/common.h) + +-find_package(Boost REQUIRED COMPONENTS chrono filesystem signals system) ++find_package(Boost REQUIRED COMPONENTS chrono filesystem system) + + include_directories(include ${CATKIN_DEVEL_PREFIX}/${CATKIN_GLOBAL_INCLUDE_DESTINATION}/ros ${catkin_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS}) + +diff --git a/test/test_roscpp/CMakeLists.txt b/test/test_roscpp/CMakeLists.txt +index 41ed980..d84cfe2 100644 +--- a/test/test_roscpp/CMakeLists.txt ++++ b/test/test_roscpp/CMakeLists.txt +@@ -11,7 +11,7 @@ find_package(catkin REQUIRED COMPONENTS + ) + + if(CATKIN_ENABLE_TESTING) +- find_package(Boost REQUIRED COMPONENTS signals filesystem system) ++ find_package(Boost REQUIRED COMPONENTS filesystem system) + + include_directories(include ${catkin_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS}) + +diff --git a/utilities/message_filters/CMakeLists.txt b/utilities/message_filters/CMakeLists.txt +index e29f5fc..922e4fa 100644 +--- a/utilities/message_filters/CMakeLists.txt ++++ b/utilities/message_filters/CMakeLists.txt +@@ -13,7 +13,7 @@ catkin_package( + ) + catkin_python_setup() + +-find_package(Boost REQUIRED COMPONENTS signals thread) ++find_package(Boost REQUIRED COMPONENTS thread) + + include_directories(include ${catkin_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS}) + link_directories(${catkin_LIBRARY_DIRS}) diff --git a/debian/patches/series b/debian/patches/series index e838a18..afdc96b 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -6,3 +6,4 @@ 0006-Use-system-libb64.patch 0007-fixing-string-check.patch 1741.patch +0009-Do-not-use-Boost.Signals-any-more.patch -- 2.26.0.rc2
ros-ros-comm.log.gz
Description: application/gzip
signature.asc
Description: OpenPGP digital signature
