On Thu, Mar 19, 2020 at 11:34:19AM +0100, gregor herrmann wrote: > On Tue, 26 Nov 2019 21:27:14 +0200, Damyan Ivanov wrote: > > > -=| gregor herrmann, 25.11.2019 21:38:54 +0100 |=- > > > On Mon, 18 Nov 2019 12:42:55 +0000, Iain Lane wrote: > > > > > > > I think it'd be cool if this were instead to support globbing. If I were > > > > to propose a merge request which changes this into a glob (Text::Glob?), > > > > would you merge that? > > > > > > I think the idea totally makes sense, and if the change is > > > backwards-compatible and doesn't pose any other issue I don't see why > > > we wouldn't take it. > > > > > > Maybe Dam who wrote the webhook support has some ideas on how to best > > > implement it or can share other thoughts. > > > > I think that using Text::Glob is a nice idea. > > > > Reading Text::Glob(3pm) I noticed that '/' is treated specially - '*' > > doesn't match it. Hopefully that's not a deal breaker. > > > > Going for full regular expression support seems overkill, and > > dangerous. > > > > So, please, Iain, send that merge request. Thanks! > > The merge request exists, thanks Iain! > > https://salsa.debian.org/kgb-team/kgb/-/merge_requests/7
Ah yeah, I should have updated the bug. > To me it looks good, and I especially appreciate the added tests. > Iain, I guess you tested the changes also with a test installation, > as discussed on IRC? I did, yes - and it seems to work as designed. Thanks for the initial review! Hopefully once this is merged the "production" instances can be updated to use it? Then I can fix pkg-gnome's webhooks to not spam #debian-gnome :-). Cheers, -- Iain Lane [ i...@orangesquash.org.uk ] Debian Developer [ la...@debian.org ] Ubuntu Developer [ la...@ubuntu.com ]
signature.asc
Description: PGP signature
