Hi Daniel, On Fri, Feb 21, 2020 at 12:50:46AM +0000, Daniel Shahaf wrote: > Thanks for the review!
well, I only glimpsed over it so far..
> > why is php5 mentioned here?
> I based the new test on the existing "simple ($awk)" test. That test
> uses php5 as the example, so that carried over to the new test.
>
> However, I suspect that doesn't answer your question. Could you clarify
> it, please?
I missed the fact that this is just a test ;) (see above)
> > > I'm not sure if the handling of the ":amd64" architecture suffixes is
> > > ideal. Thoughts?
> Okay, so what would you prefer? To have --except=foo match both
> foo and foo:bar for any value of bar? (and 'foo' documented as
> a bare package name without a ":arch" suffix)
yes, that.
thanks!
--
cheers,
Holger
-------------------------------------------------------------------------------
holger@(debian|reproducible-builds|layer-acht).org
PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
signature.asc
Description: PGP signature
