Package: clutter-1.0 Version: 1.26.2+dfsg-12 Severity: minor Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu focal ubuntu-patch
Dear maintainers, In Ubuntu, we are in the process of moving the i386 architecture to a compatibility-only layer on amd64, and therefore we are also moving our autopkgtest infrastructure to test i386 binaries in a cross-environment. This requires changes to some tests so that they are cross-aware and can do the right thing. The clutter-1.0 tests currently fail in this environment, because they are build tests that do not invoke the toolchain in a cross-aware manner. I've verified that the attached patch lets the tests successfully build (and run) i386 tests on an amd64 host. Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this is a complete no-op in Debian for the moment. Support for cross-testing in autopkgtest is currently awaiting review at https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once landed, will still have no effect unless autopkgtest is invoked with a '-a' option. So this change should be safe to land in your package despite this not being upstream in autopkgtest. Thanks for considering, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
diff -Nru clutter-1.0-1.26.2+dfsg/debian/tests/build clutter-1.0-1.26.2+dfsg/debian/tests/build --- clutter-1.0-1.26.2+dfsg/debian/tests/build 2019-08-27 02:44:04.000000000 -0700 +++ clutter-1.0-1.26.2+dfsg/debian/tests/build 2019-12-06 10:28:51.000000000 -0800 @@ -11,6 +11,12 @@ export XDG_RUNTIME_DIR="$WORKDIR" trap "rm -rf $WORKDIR" 0 INT QUIT ABRT PIPE TERM cd $WORKDIR + +if [ -n "$DEB_HOST_MULTIARCH" ]; then + export PKG_CONFIG_PATH="/usr/lib/$DEB_HOST_MULTIARCH/pkgconfig" + CROSS_COMPILE="$DEB_HOST_GNU_TYPE-" +fi + cat <<EOF > cally.c #include <cally/cally.h> @@ -53,7 +59,7 @@ ;; esac - gcc -o "${lib}-test" "${code}" $(pkg-config --cflags --libs ${packages}) + ${CROSS_COMPILE}gcc -o "${lib}-test" "${code}" $(pkg-config --cflags --libs ${packages}) echo "build ($lib): OK" [ -x "${lib}-test" ] dbus-run-session -- xvfb-run -a "./${lib}-test"