Hi Antoine, > [...] > Could you hook up the test suite in autopkgtest somehow?
I prepared a debian/tests/control, but upstream's test suite does not
successfully run on any of my Debian machines, neither when I run 'tox'
(as suggested in docs/contributing.rst), nor if I call pytest-3
directly. I contacted upstream, but did not yet get a reply. Thus,
I'd like to defer enabling the autopkgtest stuff.
> The docbase stuff is usually in HTML, and to make it work you'd need to
> build it with the Sphinx package, I think. It would be better to split
> that out in a separate -doc package.
Sounds reasonable to me. I put it on my todo list.
> Why did you mark the FHS patch as not needing forward? It would seem
> like a useful contribution for upstream...
Changed the mark to 'no' and am planning to forward soon.
> All this can be done in a future incantation though.
>
> The stuff on mentors still has an empty postrm script, so it looks like
> it's not exactly the same state as the merge request...
>
> python-git-revise-doc.docs refers to two non-existent files, so that
> should definitely be fixed. It would be strange to have README.source
> shipped, btw. And README.Debian doesn't need to be in the -doc package.
thanks! I didn't see that. The .docs file is now removed.
> For the (build-)depends, you might want to split lines on commas to make
> future diffs smaller. You can also build-dep on debhelper-compat to pin
> an exact version, which also removes the need for the extra
> debian/compat file.
Thanks for the pointers, done.
> Did you audit or review the upstream source?
Finally, yes. I read completely through the git-revise code (but not
the test suite, yet).
I uploaded the new version to mentors [1] and this time the sources
should be equivalent to the ones in
https://salsa.debian.org/debian/git-revise -b debian/sid
with the exception of the actual changelog-Release commit (that is only
in https://salsa.debian.org/nsc-guest/git-revise).
As soon as the package is uploaded one day, I will create these bugs:
- Use upstream's test suite for autopkgtest
- split-out a git-revise-doc package with HTML docs and proper docbase
integration
Can you please have a look at the upload, once again?
Thanks and kind regards,
Nicolas
[1]: https://mentors.debian.net/package/git-revise
--
epost: nico...@fjasle.eu irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --
signature.asc
Description: PGP signature
