Bug#904083: Regression run_lintian calls lintian with a non existing filename

[Maximiliano Curia]

¡Hola Johannes!

El 2019-01-04 a las 19:35 +0100, Johannes Schauer escribió:

Quoting Maximiliano Curia (2019-01-04 19:01:52)

On Thu, 19 Jul 2018 13:08:02 +0200 Maximiliano Curia <m...@debian.org>
wrote:

With the new release of sbuild 0.77 (which moves the run_lintian call outside
of the build function), lintian receives the name of a no longer existing
changes file (as the unlink is part of the copy_changes) and as such it fails
with, for example:
 I: schroot -d /<<BUILDDIR>> -c 
unstable-amd64-sbuild-a8e6ff65-a882-41b6-9ce3-b5e764b4ca8c --run-session -q -u maxy -p -- 
lintian -I --pedantic --show-overrides sddm_0.18.0-1_amd64.changes
 D: Running command: schroot -d /<<BUILDDIR>> -c 
unstable-amd64-sbuild-a8e6ff65-a882-41b6-9ce3-b5e764b4ca8c --run-session -q -u maxy -p -- 
lintian -I --pedantic --show-overrides sddm_0.18.0-1_amd64.changes
 warning: "sddm_0.18.0-1_amd64.changes" cannot be processed.
 warning: It is not a valid lab query and it is not an existing file.

 E: Lintian run failed (runtime error)

The issue is not present using the 0.76 version, and can be workaround
commenting the unlink call from the copy_changes function (as shown in the
attached file).

Thanks for working in sbuild. :)

I really fail to reproduce your problem. Can you give me your exact sbuild
invocation so that I may be able to see the same error that you see? I see it
neither in the version currently in unstable nor in git master.

I'm currently using sbuild 0.77.1-2, calling it with:
 sbuild --dist=sid --arch=amd64 --chroot=sid-amd64-sbuild --arch-all --arch-any --source 
--run-lintian --lintian-opts="-I --pedantic --show-overrides" --no-run-piuparts 
--purge=never /home/maxy/debian/kde/frameworks/build-area/breeze-icons_5.53.0-1~.dsc

An it fails as long as the mentioned unlink is present.

This is really odd.

I tried your command and it works just fine over here.

How did you set up your chroot?

Can you try to set everything up inside a virtual machine or some such? Just to
have a fresh start and a step-by-step instruction of how to get to your error?

Happy hacking,
--

-- David Jones
Saludos /\/\ /\ >< `/

Apparently this issue is reproducible only when the host machine (the machine running sbuild) has a symlink from /var/lib/sbuild/build to /build. I've created this symlink long ago in my previous machine, and today, after creating the symlink in my new machine the lintian errors started showing up. Deleting the symlink makes the builds work as expected. I guess the unlink is being ignored on machines that don't have a /build, but its likely to be bogus non the less. "Get your data structures correct first, and the rest of the program will write itself"

signature.asc
Description: PGP signature