Package: devscripts
Version: 2.19.6
Severity: normal
Tags: patch

Dear Maintainer,

since bug fix

https://salsa.debian.org/debian/devscripts/commit/25d09affb98dfcfd17dfe3ee4646fe0fd0f9ed73

'spawn' is used instead of 'system' to install packages.

This makes debi return immediately, making it (at least) unsuitable for 
scripting.

Attaching a naive patch, returning all calls back to 'system', which works fine 
for me.

Hth!

S

-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DEBCLEAN_CLEANDEBS=yes
DEBUILD_PREPEND_PATH=/usr/lib/ccache

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-0.bpo.5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages devscripts depends on:
ii  dpkg-dev                   1.19.7
ii  fakeroot                   1.23-1
ii  file                       1:5.37-4
ii  gnupg                      2.2.17-3
ii  gnupg2                     2.2.17-3
ii  gpgv                       2.2.17-3
ii  libc6                      2.28-10
ii  libfile-homedir-perl       1.004-1
ii  libfile-which-perl         1.23-1
ii  libipc-run-perl            20180523.0-1
ii  libmoo-perl                2.003004-2
ii  libstring-shellquote-perl  1.04-1
ii  libwww-perl                6.39-1
ii  patchutils                 0.3.4-2
ii  perl                       5.28.1-6
ii  python3                    3.7.3-1
ii  sensible-utils             0.0.12
ii  wdiff                      1.2.2-2+b1

Versions of packages devscripts recommends:
ii  apt                         1.8.2
ii  at                          3.1.23-1
ii  curl                        7.65.1-1
ii  dctrl-tools                 2.24-3
ii  debian-keyring              2019.06.25
ii  dput                        1.0.3
ii  equivs                      2.2.0
ii  libdistro-info-perl         0.21
ii  libdpkg-perl                1.19.7
ii  libencode-locale-perl       1.05-1
pn  libgit-wrapper-perl         <none>
pn  libgitlab-api-v4-perl       <none>
ii  liblist-compare-perl        0.53-1
ii  liblwp-protocol-https-perl  6.07-2
ii  libsoap-lite-perl           1.27-1
ii  libtry-tiny-perl            0.30-1
ii  liburi-perl                 1.76-1
pn  licensecheck                <none>
ii  lintian                     2.16.0
ii  man-db                      2.8.5-2
ii  patch                       2.7.6-5
ii  python3-apt                 1.8.4
ii  python3-debian              0.1.35
ii  python3-magic               2:0.4.15-2
ii  python3-requests            2.21.0-1
pn  python3-unidiff             <none>
pn  python3-xdg                 <none>
ii  strace                      4.26-0.2
ii  unzip                       6.0-24
ii  wget                        1.20.3-1
ii  xz-utils                    5.2.4-1

Versions of packages devscripts suggests:
pn  adequate                     <none>
ii  autopkgtest                  5.10
pn  bls-standalone               <none>
ii  bsd-mailx [mailx]            8.1.2-0.20180807cvs-1
ii  build-essential              12.6
pn  check-all-the-things         <none>
pn  cvs-buildpackage             <none>
ii  debhelper                    12.2.3
pn  devscripts-el                <none>
ii  diffoscope                   118
pn  disorderfs                   <none>
pn  dose-extra                   <none>
pn  duck                         <none>
ii  faketime                     0.9.7-3
pn  gnuplot                      <none>
pn  how-can-i-help               <none>
pn  libauthen-sasl-perl          <none>
pn  libdbd-pg-perl               <none>
ii  libfile-desktopentry-perl    0.22-1
pn  libnet-smtps-perl            <none>
pn  libterm-size-perl            <none>
ii  libtimedate-perl             2.3000-2
pn  libyaml-syck-perl            <none>
ii  mailutils [mailx]            1:3.6-1+b1
pn  mozilla-devscripts           <none>
pn  mutt                         <none>
ii  openssh-client [ssh-client]  1:8.0p1-3
pn  piuparts                     <none>
pn  postgresql-client            <none>
ii  quilt                        0.65-3
pn  ratt                         <none>
pn  reprotest                    <none>
ii  svn-buildpackage             0.8.7
pn  w3m                          <none>

-- no debconf information
>From 41cf496af78b667fe73542f6f8dcf5b8543be50a Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Stephan=20S=C3=BCrken?= <abs...@olurdix.de>
Date: Wed, 24 Jul 2019 14:32:36 +0200
Subject: [PATCH] scripts/debi.pl: Replace 'spawn' by 'system' (Fixes: debi
 detaches).

---
 scripts/debi.pl | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/scripts/debi.pl b/scripts/debi.pl
index 34af910f..710f85fc 100755
--- a/scripts/debi.pl
+++ b/scripts/debi.pl
@@ -413,17 +413,16 @@ if ($progname eq 'debi') {
     my @upgrade = $opt_upgrade ? ('-O') : ();
     if ($opt_with_depends) {
         if ($install_tool =~ /^apt(?:-get)?$/) {
-            spawn(exec => [$install_tool, 'install', "./$changes"]);
+            system($install_tool, 'install', "./$changes");
         } else {
-            spawn(exec => ['debpkg', @upgrade, '--unpack', @debs]);
-            spawn(exec => [$install_tool, '-f', 'install']);
+            system('debpkg', @upgrade, '--unpack', @debs);
+            system($install_tool, '-f', 'install');
         }
     } else {
         if ($install_tool =~ /^apt(?:-get)?$/) {
-            spawn(exec =>
-                  [$install_tool, 'install', '--only-upgrade', "./$changes"]);
+            system($install_tool, 'install', '--only-upgrade', "./$changes");
         } else {
-            spawn(exec => ['debpkg', @upgrade, '-i', @debs]);
+            system('debpkg', @upgrade, '-i', @debs);
         }
     }
 } else {
-- 
2.22.0

Reply via email to