Hi Andr, > This does not work if SOURCE_DATE_EPOCH is set because the unnamed > argument has with two '+' characters (one from DATE_FMT and one > from the command line).
Mea culpa; I must have copy-pasted too hastily from my terminal to my email editor (also causing the quotes and LC_ALL confusion) from a previous iteration of my patch. > Also DATE_FMT should be a singly expanded make variable. (Singly, as in ":=" vs "=" ?) > Care to provide a commit message which explains why we try to > pass $(SOURCE_DATE_EPOCH) as an argument to both -d and -r, who > sets SOURCE_DATE_EPOCH, and what type its value is supposed to be > (filename or number of seconds)? In terms of a its value, probably best to canonically link to: https://reproducible-builds.org/specs/source-date-epoch/ … although as a spoiler, it is a UNIX timestamp. :) Thanks for your review. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org 🍥 chris-lamb.co.uk `-
