Control: clone 929636 -1 Control: retitle -1 simple-cdd: qemu options are not supported since rewrite
On 2019-05-27, Marc Fargas wrote:
> At the very end of the detailed example (simple-cdd.conf.detailed.gz)
> the following appears:
>
> # memory available within qemu, in MB
> #mem=96
>
> # additional options that get passed to qemu
> #qemu_opts="-std-vga"
>
> But these options have no effect at all.
>
> Looking at the run_qemu() function in build-simple-cdd it appears that
> this is not implemented. qemu_opts is a blank list, while 'mem' there's
> a comment that looks like it comes from a previous shell script base
> version, but never got implemented.
>
> While it remains not implemented, the sample file should state so.
> Though I'm not sure why it's not implemented, from a quick grasp of the
> code, it looks like the commented section should read:
>
> if self.env.get('mem'):
> qemu_opts.append('-m')
> qemu_opts.append(self.env['mem'])
Will apply at least this fix, but qemu isn't all that well supported
since the transition to python...
The "test" profile, which uses the simple-cdd's qemu-specific support,
appears to be largely broken, thus cloning this bug.
If you could propose more patches to fix it, it'd be great!
live well,
vagrant
signature.asc
Description: PGP signature
