Please use snprintf (or asprintf, which is less portable) or at least
strncat rather than strcat, and strchr rather than strstr.  Then rport
and rcommand don't need to be initialized.  numtokens() is totally
unused.  I would suggest to replace gettoken() with some higher level
functions, either strtok or strsep or looping around strstr.

In particular, it should return NULL on error, rather than some empty
string "", which will be misinterpretted by the higherlevel routine,
rather than signaling an error for it to handle.

Justin


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to