Hi Johannes,

On  Mo 01 Apr 2019 12:46:32 CEST, Johannes Schauer wrote:

Control: tag -1 + patch

Hi,

Quoting Mike Gabriel (2019-04-01 12:22:42)
Package: sbuild
Version: 0.78.1-1
Severity: important

Hi,

the members of the Freexian Extended LTS team need to be able to build
packages for wheezy.

I have recently upgraded my notebook to Debian 10 (pre) and from then
on it failed building packages for wheezy-lts via sbuild.

```
+------------------------------------------------------------------------------+
| Install package build dependencies
         |
+------------------------------------------------------------------------------+


Setup apt archive
-----------------

Merged Build-Depends: debhelper (>= 9), libpam0g-dev, libselinux1-dev,
libaudit-dev, build-essential, fakeroot
Filtered Build-Depends: debhelper (>= 9), libpam0g-dev,
libselinux1-dev, libaudit-dev, build-essential, fakeroot
dpkg-deb: building package `sbuild-build-depends-main-dummy' in
`/<<RESOLVERDIR>>/apt_archive/sbuild-build-depends-main-dummy.deb'.
gzip: unrecognized option '--keep'
Try `gzip --help' for more information.
gzip failed: 256
E: cannot create dummy archive
Failed to run apt-ftparchive.
E: Setting up apt archive failed
```

I currently run a slightly patched version of sbuild (.debdiff is
attached). With the below patch, I can build packages for wheezy again:

```
diff -Nru sbuild-0.78.1/debian/patches/support-gzip-in-wheezy.patch
sbuild-0.78.1/debian/patches/support-gzip-in-wheezy.patch
---
sbuild-0.78.1/debian/patches/support-gzip-in-wheezy.patch       1970-01-01
01:00:00.000000000 +0100
+++
sbuild-0.78.1/debian/patches/support-gzip-in-wheezy.patch       2019-04-01
11:33:06.000000000 +0200
@@ -0,0 +1,16 @@
+Description: gzip in wheezy lacks --keep option, so avoid using it.
+Author: Mike Gabriel <[email protected]>
+
+--- a/lib/Sbuild/ResolverBase.pm
++++ b/lib/Sbuild/ResolverBase.pm
+@@ -1445,8 +1445,8 @@
+     closedir($dh);
+ }
+
+-system('gzip', '--keep', '--force', 'Packages') == 0 or die "gzip
failed: $?\n";
+-system('gzip', '--keep', '--force', 'Sources') == 0 or die "gzip
failed: $?\n";
++system('gzip -c --force Packages > Packages.gz') == 0 or die "gzip
failed: $?\n";
++system('gzip -c --force Sources  > Sources.gz' ) == 0 or die "gzip
failed: $?\n";
+
+ my $packages_md5 = hash_file('Packages', 'md5sum');
+ my $sources_md5 = hash_file('Sources', 'md5sum');
```

indeed I was not aware that the --keep option is a relatively recent addition
to gzip. Does wheezy sbuild at least have the short option or is it completely
missing?

Wheezy's gzip (not sbuild, as written above) lacks the --keep functionality entirely. So neither "--keep" and nor "-k" are available.

Why do you think is this issue of severity important? Did you contact the
release team about a possible freeze exception?

I assume that the RT will make a freeze exception for the above patch. One member of the release team is also an ELTS contributor (Emilio, in Cc:). Keeping Debian's tool chains intact, also for team's providing security support for old versions of Debian, seems justification enough for setting this bug's severity to important.

If you don't have a good feeling with this, could you still provide a package upgrade proposal (as .debdiff) and I let the RT pre-approve the to-be-uploaded package?

Thanks+Greets,
Mike



--

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: [email protected], http://das-netzwerkteam.de

Attachment: pgpRLToT8PgqX.pgp
Description: Digitale PGP-Signatur

Reply via email to