Control: tags -1 +pending
[2019-03-15 22:15] Lorenzo Puliti <[email protected]> > Package: runit > Version: 2.1.2-25helpers1 > Severity: normal > Tags: patch > > Hi, > > I've just find out about #919296, so I realised that runit's update-service > (used in git-daemon maint scripts) is using a different path for supervise > directory. > In the attached patch i'm changing that path to be consistent with the one > used by dh-runit (both service and log). Thank you. Applied. > But also I spot another difference: > a directory inside supervise created by dh-runit has mode 755 while the one > created by runsv (with update-service) has mode 700. > For example: > # ls -l /var/lib/supervise/ | grep elogind > drwx------ 2 root root 4096 Mar 15 19:11 elogind > drwx------ 2 root root 4096 Mar 15 19:11 elogind.log > > # ls -l /var/lib/runit/supervise/ | grep getty-tty2 > drwxr-xr-x 2 root root 4096 Mar 15 19:11 getty-tty2 > > With mode 755 both the pid file and the stat file are world readable.. > Maybe mode 700 is safer? While I do not see how it is dangerous, since pid files under /run are world-readable: $ cat /run/*.pid 1961 25505 25561 2437514 2475 25495 9699 $ whoami iu ... I agree, that 700 feels better. Mind to file separate bug against dh_runit? -- Note, that I send and fetch email in batch, once every 24 hours. If matter is urgent, try https://t.me/kaction --
