Control: tags -1 +patch
On Sat, Feb 16, 2019 at 10:21 AM Scott Kitterman <[email protected]> wrote:
> It would have been nice if you had investigated the impact of dropping icu-
> config. The postfix build system uses the presence of icu-config to determine
> if libicu is present (and thus SMTPUTF8 support should be built in). See
> #921075.
I did build testing and postfix compiled successfully without any
warning that an important library for its working might be missing.
I don't have the expertise to fire up test mail servers to investigate
its functionality in every aspect.
> In my opinion, postfix is not releasable in its current state. Please put
> icu-config back or provide a tested alternative to enable postfix to build
> correctly.
No offense at all, just a note that the fix might take shorter time
than writing your email. It is attached and you need to add pkg-config
to your build dependencies.
Postfix is build tested very closely. Now it builds _without_ the
NO_EAI flag and links to ICU correctly. Still can't run it (I don't
have a server nor VM), but if you may give me a test case showing it
might still not work then I will do everything to fix it.
Regards,
Laszlo/GCS
--- postfix-3.3.2.orig/makedefs
+++ postfix-3.3.2/makedefs
@@ -802,8 +802,8 @@ esac
#
case "$CCARGS" in
*-DNO_EAI*) CCARGS="$CCARGS "'-DDEF_SMTPUTF8_ENABLE=\"no\"';;
- *) icu_cppflags=`(icu-config --cppflags) 2>/dev/null` && {
- icu_ldflags=`(icu-config --ldflags) 2>/dev/null` && {
+ *) icu_cppflags=`(pkg-config --cflags icu-i18n) 2>/dev/null` && {
+ icu_ldflags=`(pkg-config --libs icu-i18n) 2>/dev/null` && {
trap 'rm -f makedefs.test makedefs.test.[co]' 1 2 3 15
cat >makedefs.test.c <<'EOF'
#include <unicode/uidna.h>
