On Sat, 2006-03-18 at 09:49 +0100, Bart Martens wrote:
> On Fri, Mar 17, 2006 at 11:23:13PM +0100, Arthur de Jong wrote:
> > Subject: flashplugin-nonfree: please use /var/tmp instead
> > of /var/run
> 
> The patch doesn't seem to use /var/tmp.  Would it be OK to create the
> temporary directory in /tmp instead ?

The bugreport was written before the patch and I forgot to adapt the
subject.

> > The attached patch uses mktemp to create a temporary directory in the
> > default /tmp directory (which can be set by the TMPDIR environment
> > variable).
> > +           TMPDIR=`mktemp -d flashplugin-nonfree.XXXXXX`
> 
> The patch seems to create a temporary directory in the current
> directory, not in /tmp.  I guess adding "-p /tmp" should solve this.

Oops. The -t option should also be passed to mktemp to create it in a 
temporary directory. I always seem to get mktemp and tempfile mixed up.

> I would use UNPACKDIR instead of TMPDIR to store the result of mktemp,
> because TMPDIR already has a special meaning to mktemp.

Good point.

-- 
-- arthur - [EMAIL PROTECTED] - http://people.debian.org/~adejong --

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to