Hello!
On Tue, 23 Nov 2004 16:04:21 +0100, Daniel Barlow wrote:
> From: Kevin Rosenberg <[EMAIL PROTECTED]>
> Subject: improved attachtty.c patch
[...]
> Adds timeout and improved socket writing:
[...]
> + if(argc<2 || argc>4) {
> + fprintf(stderr, "%s: unrecognized arguments\nusage: %s /path/to/socket
> [cmd]\n %s [EMAIL PROTECTED]:/path/to/socket [cmd] [timeout]\n",
> argv[0], argv[0], argv[0]);
> exit(1);
> }
I think that the error message above is incorrect, because the timeout
option is available only with a local connection, as from below:
> if(host) {
> logprintf("attachtty","connecting through ssh to %s on %s\n",path,host);
> - connect_ssh(host,path);
> + connect_ssh(host,path,cmd);
> } else {
> logprintf("attachtty","connecting directly to %s\n",path);
> - connect_direct(path);
> + connect_direct(path,cmd,timeout);
> }
So, a patch over kmr patch is attached. This patch is against the
BESE darcs repository at [1], which has other minor fixes.
Thx, bye,
Gismo / Luca
[1] http://common-lisp.net/project/bese/repos/detachtty/
detachtty_correct-error-timeout_20060318.patch.gz
Description: attachtty.c: correct error message for timeout option
pgpzqhocFDONL.pgp
Description: PGP signature
