On 2018-12-10, Wolfgang Schweer wrote:
> On Sat, Dec 08, 2018 at 03:08:22PM +0100, Vagrant Cascadian wrote:
>> On 2018-12-07, Vagrant Cascadian wrote:
>> But it's also possible to have some mirrors include a file:/// url
>> that's trusted and some that are not... so it needs to be specified on a
>> per-mirror basis.
>
> Just another try w/ conditionally added trust; the attached patch seems 
> to work for me, please check.

> Wolfgang
> From 7106088bcbd7d0a0a49144b66ab10ab2f943e9d6 Mon Sep 17 00:00:00 2001
> From: Wolfgang Schweer <[email protected]>
> Date: Mon, 10 Dec 2018 11:02:26 +0100
> Subject: [PATCH] Debian: ltsp-build-client: Trust file:/ mirrors that point to
>  /media/cdrom to be able to use a CDROM now that file:/// mirrors are no
>  longer trusted by default. https://bugs.debian.org/911380

This seems too fragile; if /media/cdrom changes yet again, it will
break. But the code I committed to ltsp upstream doesn't work either for
a wide variety of reasons... this is turning out to be very messy...

I'm now thinking of passing an option --trust-file-mirrors or something
like that. Then the trust is explicit, consistent with apt behavior
requiring to explicitly trust it. It wouldn't allow different levels of
trust for different file mirror types, but it will at least be simpler
to code...


It's also hard to invest in ltsp-build-client at this point;
ltsp-build-client should be deprecated entirely, as it's already not the
recommended way to install LTSP... but there's a lot of work left to do
to really drop it.


live well,
  vagrant

Reply via email to