Gürkan Myczko wrote:
> Can you confirm this update is right?
> 
> http://phd-sid.ethz.ch/debian/fortunate.app/fortunate.app_3.1-2.dsc

Basically yes, just a few remarks:

* It's better to use dh_auto_build instead of $(MAKE) in the
  dh_auto_build override; that way options for parallel builds (-jN)
  will propagate automatically:

override_dh_auto_build:
        dh_auto_build -- $(optim) messages=yes $(shell dpkg-...

* The "optim" variable is already defined conditionally in
  /usr/share/GNUstep/debian/config.mk; there is no need to define it
  again.  Just build-depend on gnustep-make (>= 2.7.0-3).

* The dh_clean override seems unnecessary?

* As you're moving Resources to /usr/share you need to add a
  maintscript with dir_to_symlink to handle the transition.

> maybe also add the vcs fields and the repo to salsa.d.o?

Sure, feel free to import it at Salsa.

Reply via email to