Package: lintian-brush
Version: 0.1
Severity: important
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Thanks for writing lintian-brush, this looks really helpful. But
currently it has its quirks:
% lintian-brush --list-tags
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 66, in
import_dulwich
from dulwich import __version__ as dulwich_version
ModuleNotFoundError: No module named 'dulwich'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/bin/lintian-brush", line 11, in <module>
load_entry_point('lintian-brush==0.1', 'console_scripts', 'lintian-brush')()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 484, in
load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2714,
in load_entry_point
return ep.load()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2332,
in load
return self.resolve()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2338,
in resolve
module = __import__(self.module_name, fromlist=['__name__'], level=0)
File "/usr/lib/python3/dist-packages/lintian_brush/__main__.py", line 63, in
<module>
wt = WorkingTree.open('.')
File "/usr/lib/python3/dist-packages/breezy/workingtree.py", line 205, in open
control = controldir.ControlDir.open(path, _unsupported=_unsupported)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 710, in open
_unsupported=_unsupported)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 739, in
open_from_transport
find_format, transport, redirected)
File "/usr/lib/python3/dist-packages/breezy/transport/__init__.py", line
1638, in do_catching_redirections
return action(transport)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 727, in
find_format
probers=probers)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 1163, in
find_format
return prober.probe_transport(transport)
File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 119, in
probe_transport
lazy_check_versions()
File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 82, in
lazy_check_versions
import_dulwich()
File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 69, in
import_dulwich
"bzr-git: Please install dulwich, https://www.dulwich.io/";)
breezy.errors.DependencyNotPresent: Unable to import library "dulwich":
bzr-git: Please install dulwich, https://www.dulwich.io/
After installing python3-dulwich, it gets better but the end
indicates some other problem:
% lintian-brush --list-tags
ancient-python-version-field
control-file-with-CRLF-EOLs
copyright-has-crs
debian-control-has-empty-field
debian-control-has-obsolete-dbg-package
debian-rules-should-not-use-pwd
debian-upstream-obsolete-path
debian-watch-uses-insecure-uri
dh-quilt-addon-but-quilt-source-format
dm-upload-allowed-is-obsolete
file-contains-trailing-whitespace
homepage-field-uses-insecure-uri
insecure-copyright-format-uri
malformed-dm-upload-allowed
missing-debian-source-format
missing-vcs-browser-field
out-of-date-copyright-format-uri
package-uses-deprecated-source-override-location
priority-extra-is-replaced-by-priority-optional
quilt-series-without-trailing-newline
transitional-package-should-be-oldlibs-optional
unnecessary-testsuite-autopkgtest-field
unversioned-copyright-format-uri
vcs-field-uses-insecure-uri
vcs-field-uses-not-recommended-uri-format
wrong-debian-qa-group-name
xc-package-type-in-debian-control
xs-testsuite-field-in-debian-control
xs-vcs-field-in-debian-control
Traceback (most recent call last):
File "/usr/bin/lintian-brush", line 11, in <module>
load_entry_point('lintian-brush==0.1', 'console_scripts', 'lintian-brush')()
TypeError: 'module' object is not callable
Running it in a random source package git repo also throws some
tracebacks:
% lintian-brush
Running fixer <ScriptFixer('ancient-python-version-field.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('control-file-with-CRLF-EOLs.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('copyright-has-crs.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('debian-control-has-empty-field.py')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Committing to:
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl/
modified debian/changelog
modified debian/control
Committed revision 475.
Running fixer <ScriptFixer('debian-control-has-obsolete-dbg-package.py')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Traceback (most recent call last):
File
"/usr/share/lintian-brush/fixers/debian-control-has-obsolete-dbg-package.py",
line 54, in <module>
raise Exception("no debug packages found to remove")
Exception: no debug packages found to remove
No files deleted.
Fixer <ScriptFixer('debian-control-has-obsolete-dbg-package.py')> failed to run
Running fixer <ScriptFixer('debian-rules-should-not-use-pwd.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('debian-upstream-obsolete-path.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('debian-watch-uses-insecure-uri.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('dh-quilt-addon-but-quilt-source-format.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('dm-upload-allowed-is-obsolete.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('file-contains-trailing-whitespace.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('homepage-field-uses-insecure-uri.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('insecure-copyright-format-uri.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('malformed-dm-upload-allowed.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('missing-debian-source-format.py')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('missing-vcs-browser-field.py')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('out-of-date-copyright-format-uri.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer
<ScriptFixer('package-uses-deprecated-source-override-location.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
File missing
No files deleted.
Fixer <ScriptFixer('package-uses-deprecated-source-override-location.sh')>
failed to run
Running fixer
<ScriptFixer('priority-extra-is-replaced-by-priority-optional.py')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('quilt-series-without-trailing-newline.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer
<ScriptFixer('transitional-package-should-be-oldlibs-optional.py')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('unnecessary-testsuite-autopkgtest-field.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('unversioned-copyright-format-uri.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('vcs-field-uses-insecure-uri.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('vcs-field-uses-not-recommended-uri-format.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('wrong-debian-qa-group-name.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('xc-package-type-in-debian-control.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('xs-testsuite-field-in-debian-control.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer <ScriptFixer('xs-vcs-field-in-debian-control.sh')> on
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Traceback (most recent call last):
File "/usr/bin/lintian-brush", line 11, in <module>
load_entry_point('lintian-brush==0.1', 'console_scripts', 'lintian-brush')()
TypeError: 'module' object is not callable
Hm, and the change it makes (for debian-control-has-empty-field, a
tag which lintian doesn't report for this package) doesn't make me
happy because the empty control field is not a field but a
"# comment" in debian/control.
And I'm wondering where it gets the email address for the commit
from, it's not the one from ~/.gitconfig.
And the changelog entry has a space before the final full stop.
Looking forward to the further development of lintian-brush!
Cheers,
gregor
- -- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'unstable-debug'), (500,
'oldoldstable'), (500, 'experimental'), (500, 'testing'), (500, 'stable'),
(500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.18.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=de_AT.utf8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled
Versions of packages lintian-brush depends on:
ii dos2unix 7.4.0-1
ii python3 3.6.7-1
ii python3-breezy 3.0.0~bzr7141-3
ii python3-debian 0.1.33
Versions of packages lintian-brush recommends:
ii lintian 2.5.110
lintian-brush suggests no packages.
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAlvW/k5fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgaiEA//fWxS9nCsbLzLrsW0Cv1VObE8YKtl0YVJQ/BitFQJHKGD8j+gq6tD8xcC
0WDAUG2pFJhQbDW5+V8mO1IdYtw/vdqBiUIxWI0eiczh8VkeYPsbhy596+iI0TBJ
ckaulSKKQnba95jj0MJpdXMJ3kvBBiiXcRDIAPLLz4htoEcJ51ZtaqMufOfNwvCI
OGwJBgSIQU/PKoPTb079YCdOdndb14eQZb57fNQLcDv821FravBaj7WR9iU5hkl1
1MJooUS+IWm7Fla74sdSOnBONM9RZ3crLOneJxzDaOShE46VsO7b+FjTHxWFZ1TO
LBnxhKmK5amg3cGanmUP2D6Q6fPt+pxiOsohP/GZyBdQPOOsh5IIGvk+LIkIHvh8
bqTklXZ8Hg0peth3VQz7tqzDYNHKYKQEKkQzHaNXrMpn+WWzn1Rb+rRupE2gV59i
9VzCUhqF/lA6KWKsqbu1bI2ZcaWmaXjvpa+xbZs7tS2ZYQtpHkeBHJuBnBqfXu4L
RI0uW/g1QBoqMedECfZ6Mz7RdLQO4cpsnXRZWGBgtOYTMGvTHA1pANl8Y4f8iqvq
nAwOFiyOkaYmUDroGqzhQyHZwMiPupO60vUdAnVMPDjOBTPpGi/CRfQzIJBjlvbs
MbJl3JuHQWE7PIK3un+oprc0WZfK1oYphTNa4RZx+cUBSyfIRmU=
=6VUV
-----END PGP SIGNATURE-----
