Package: python3.7
Version: 3.7.1-1
Severity: important
Tags: upstream
Dear Maintainer,
* What led up to the situation?
I ran the dkimpy test suite with both python3.6 and python3.7.
* What exactly did you do (or not do) that was effective (or
ineffective)?
Running the test suite with python3.6 (and 2.7) results in all tests passing.
Runngin the test suite with python3.7 causes a large number of failures.
* What was the outcome of this action?
See the upstream bug report for details:
https://bugs.launchpad.net/dkimpy/+bug/1800313
* What outcome did you expect instead?
I expected stuff not to break with the new python3 version.
I suspect something has changed in how newlines are processed (which may, in
the end, account for all the failures), specifically these test results point
in that direction:
FAIL: test_adds_crlf (dkim.tests.test_canonicalization.TestRelaxedAlgorithmBody)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 124,
in test_adds_crlf
b'Foo bar')
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 32, in
assertCanonicalForm
self.assertEqual(expected, self.func(expected))
AssertionError: b'Foo bar\r\n' != b'Foo bar\r\n\r\n'
FAIL: test_multiple_crlf_body
(dkim.tests.test_canonicalization.TestRelaxedAlgorithmBody)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 139,
in test_multiple_crlf_body
b'\r\n\r\n')
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 33, in
assertCanonicalForm
self.assertEqual(expected, self.func(input))
AssertionError: b'' != b'\r\n\r\n'
FAIL: test_single_crlf_body
(dkim.tests.test_canonicalization.TestRelaxedAlgorithmBody)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 134,
in test_single_crlf_body
b'\r\n')
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 33, in
assertCanonicalForm
self.assertEqual(expected, self.func(input))
AssertionError: b'' != b'\r\n\r\n'
FAIL: test_strips_trailing_empty_lines
(dkim.tests.test_canonicalization.TestRelaxedAlgorithmBody)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 119,
in test_strips_trailing_empty_lines
b'Foo\r\nbar\r\n\r\n\r\n')
File "/home/dkimpy.upstream/dkim/tests/test_canonicalization.py", line 32, in
assertCanonicalForm
self.assertEqual(expected, self.func(expected))
AssertionError: b'Foo\r\nbar\r\n' != b'Foo\r\nbar\r\n\r\n'
and many more similar.
Scott K
