Control: reopen -1 On Sat, Sep 29, 2018 at 02:26:43PM +0200, Pierre-Elliott Bécue wrote: > > Anyway, I like the proposal, please propose further :) > > Ack, then we can try to enhance this patch to make it fit your needs and > comply with the coding style of nm.d.o.
Turns out it's quite more involved. Today, the server that nono.d.o reached to started failing, so we got several of these: HTTPError at /process/479/am_ok/statement/create 500 Server Error: Internal Server Error for url: http://pool.sks-keyservers.net:11371/pks/lookup?search=0xFBFABDB541B5DC955BD9BA6EDB16CF5BB12525C4&options=mr&exact=on&op=get Request Method: POST Request URL: https://nm.debian.org/process/479/am_ok/statement/create Django Version: 1.10.7 Python Executable: /usr/bin/python3 Python Version: 3.5.3 Traceback: File "/usr/lib/python3/dist-packages/django/core/handlers/exception.py" in inner 42. response = get_response(request) File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _legacy_get_response 249. response = self._get_response(request) File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _get_response 187. response = self.process_exception_by_middleware(e, request) File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in _get_response 185. response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python3/dist-packages/django/views/generic/base.py" in view 68. return self.dispatch(request, *args, **kwargs) File "/srv/nm.debian.org/nm2/backend/mixins.py" in dispatch 72. return super(VisitorMixin, self).dispatch(request, *args, **kwargs) File "/usr/lib/python3/dist-packages/django/views/generic/base.py" in dispatch 88. return handler(request, *args, **kwargs) File "/usr/lib/python3/dist-packages/django/views/generic/edit.py" in post 182. if form.is_valid(): File "/usr/lib/python3/dist-packages/django/forms/forms.py" in is_valid 169. return self.is_bound and not self.errors File "/usr/lib/python3/dist-packages/django/forms/forms.py" in errors 161. self.full_clean() File "/usr/lib/python3/dist-packages/django/forms/forms.py" in full_clean 370. self._clean_fields() File "/usr/lib/python3/dist-packages/django/forms/forms.py" in _clean_fields 391. value = getattr(self, 'clean_%s' % name)() File "/srv/nm.debian.org/nm2/process/forms.py" in clean_statement 17. key = Key.objects.get_or_download(self.fpr) File "/srv/nm.debian.org/nm2/keyring/models.py" in get_or_download 106. body = self.download(fpr) File "/srv/nm.debian.org/nm2/keyring/models.py" in download 65. res.raise_for_status() File "/usr/lib/python3/dist-packages/requests/models.py" in raise_for_status 893. raise HTTPError(http_error_msg, response=self) Exception Type: HTTPError at /process/479/am_ok/statement/create Exception Value: 500 Server Error: Internal Server Error for url: http://pool.sks-keyservers.net:11371/pks/lookup?search=0xFBFABDB541B5DC955BD9BA6EDB16CF5BB12525C4&options=mr&exact=on&op=get So I think there needs to be a more systematic catch somewhere higher in the stack (that then propagates the error and get displayed in all pages that might end up with it or so). This occasion made me remember of https://bugs.debian.org/895896 - so pretty much all pages that let a user add a statement are affected. And somehow, not sure how, even pages that don't, like /process/NNN, do. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
