Axel Beckert wrote on Tue, 18 Sep 2018 18:50 +0200: > Hi Daniel, > > Daniel Shahaf wrote: > > Daniel Shahaf wrote on Tue, 18 Sep 2018 15:42 +0000: > > > Off the top of my head, we have several options: > > > > > > 1. Pass --with-pcre=foo to configure *and* make sure that configure dies > > > if pcre is not found. (The configure.ac patch can be upstreamed.) > > > > > > 2. After running configure, check that the pcre line in config.modules > > > has the expected values. (not upstreamable) > > > > > > 3. Patch Test/V07pcre to fail, rather than skip, if the PCRE module was > > > not built. (not upstreamable) > > > > > > We can do more than one of these, e.g., #1+#3. > > > > #3 is easy, attached. > > > From 9c8883c924a4b69ca0b22b0f6a851a9d5eddf07a Mon Sep 17 00:00:00 2001 > > From: Daniel Shahaf <[email protected]> > > Date: Tue, 18 Sep 2018 16:30:24 +0000 > > Subject: [PATCH] Make sure the build will fail if PCRE is not available. > > Please don't be offended, but I don't think we should use a patch for > that feature. >
Why would I be offended? Disagreement is no cause for offence. > The simplest way from my point of view is to check in an > override_dh_auto_test if the plugin file (pcre.so) is present or not. > > Something like this: > > override_dh_auto_test: > dh_auto_test > test -e [...]/zsh/pcre.so Summarising IRC discussion: - There is still benefit in making sure V07 runs rather than skips. - We'd like to minimise the delta from upstream. Therefore the revised plan is: A. Teach upstream configure to fail hard if --with-pcre was passed and pcre wasn't found. PCRE would remain optional if neither --with-pcre nor --without-pcre was passed. B. Pass --with-pcre to configure in d/rules. C. Teach upstream test V07 to make the skip conditional, not on whether pcre loads successfully, but on whether it was found by configure. (This probably means looking in config.modules or in pcre.mdd or something?) This will catch bugs where pcre was built but fails to load. A and C are both upstreamable. Cheers, Daniel
