Am 10.09.18 um 04:28 schrieb Michael Biebl: > Thanks Chris > > Am 09.09.18 um 21:31 schrieb Chris Lamb: >> Spent a couple moments on this. The first thing that can be addressed >> is the absolute CATALOG_DIR which ends up in the /usr/lib/systemd/ >> tests/test-catalog binary in the systemd-tests package. >> >> This dir is currently "useless" in that it will fail on (almost) all >> end- user systems as it points into the original build path, eg, /tmp/ >> buildd. > > test-catalog is an odd one indeed. We already special-case it in our > autopkgtests: > https://salsa.debian.org/systemd-team/systemd/blob/master/debian/tests/root-unittests#L6 > > I've filed https://github.com/systemd/systemd/issues/10045, maybe we can > find a proper solution for this or stop installing the test binary.
So, upstream has proposed a fix to make test-catalog work as installed test [1]. It still encodes the absolute build dir in the binary though. While looking at it more closely, I noticed that test-catalog is not the only test using ABS_BUILD_DIR. get_testdata_dir() from src/shared/tests.c [2] also uses it. I'm a bit uncertain about this. Those (installed) tests are bit special. They are supposed to work during "ninja test", i.e. we run them as part of the build process. But we also install them in the systemd-tests binary package so we can run them via autopkgtest later on. Now, I could try and convince upstream to not embed ABS_BUILD_DIR into the binary and maybe let the build system pass the build dir as env var. This would make those test-binaries a bit more cumbersome to use though, because you'd have to manually set the env var if you directly execute the test by hand. Since the "systemd-tests" package is a bit special, could we somehow exclude that (basically all binaries from /usr/lib/systemd/tests) from the reproducibility checks so the binaries which are shipped in that package don't make the whole src:systemd package fail? [1] https://github.com/systemd/systemd/pull/10046 [2] https://salsa.debian.org/systemd-team/systemd/blob/master/src/shared/tests.c#L40 -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
