Package: btrfsmaintenance
Version: 0.4.1-3
Severity: normal
Tags: patch

Dear Maintainer,

BTRFS_SCRUB_PRIORITY="idle" (or not setting it at all) in
/etc/default/btrfsmaintenance should cause
/usr/share/btrfsmaintenance/btrfs-scrub.sh to start scrub
with idle IO priority.

But it starts it with the default IO priority like any other
job.

The reason seems to be that the default value for ioprio
is not set:

--- /usr/share/btrfsmaintenance/btrfs-scrub.sh.old      2018-09-10 
07:19:22.082165973 +0100
+++ /usr/share/btrfsmaintenance/btrfs-scrub.sh  2018-09-10 07:19:32.201975411 
+0100
@@ -22,7 +22,7 @@
        readonly=-r
 fi
 
-ioprio=
+ioprio="-c 3"
 if [ "$BTRFS_SCRUB_PRIORITY" = "normal" ]; then
        # ionice(3) best-effort, level 4
        ioprio="-c 2 -n 4"



-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:de (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages btrfsmaintenance depends on:
ii  btrfs-progs  4.17-1
ii  cron         3.0pl1-130
ii  systemd      239-8

btrfsmaintenance recommends no packages.

btrfsmaintenance suggests no packages.

-- Configuration Files:
/etc/default/btrfsmaintenance changed:
BTRFS_LOG_OUTPUT="stdout"
BTRFS_DEFRAG_PATHS=""
BTRFS_DEFRAG_PERIOD="none"
BTRFS_DEFRAG_MIN_SIZE="+1M"
BTRFS_BALANCE_MOUNTPOINTS="/"
BTRFS_BALANCE_PERIOD="weekly"
BTRFS_BALANCE_DUSAGE="1 5 10 20 30 40 50"
BTRFS_BALANCE_MUSAGE="1 5 10 20 30"
BTRFS_SCRUB_MOUNTPOINTS="/"
BTRFS_SCRUB_PERIOD="weekly"
BTRFS_SCRUB_PRIORITY="idle"
BTRFS_SCRUB_READ_ONLY="false"
BTRFS_TRIM_PERIOD="none"
BTRFS_TRIM_MOUNTPOINTS="/"


-- no debconf information

Reply via email to