On Mon, 3 Sep 2018 16:41:58 +0200 Michael Biebl <bi...@debian.org> wrote:
> The patch looks fine to me from a cursory glance. I haven't tested it > though. Trek, I assume you built a test package and did a test-upgrade > checking it works as expected? I haven't built a test package, but instead I have patched the compiled deb package with dpkg-deb -R and dpkg-deb -b and tested the upgrade process I'll build udev from the source package in the next days, then I'll test again the upgrade process (manually removing rc*.d/K* symlinks before install the new package) and the shutdown fix > If you don't mind, would you send a git formatted patch so the changes > are properly attributed to you? I think it should not be attributed to me, as it's the result of a very collaborative work, especially (in order of appearance) Guilhem Moulin, Theppitak Karoonboonyanan, Felipe Sateler, Michael Biebl, Pali Rohár and at last me > The git commit message should follow gbp-dch style, with a Closes: > #791944. A MR via https://salsa.debian.org/systemd-team/systemd would > be even nicer. It's not a pre-requisite it just makes things more > convenient for us and speeds up processing. I'll try to do it many thanks to you! Trek
