On Mon, 27 Aug 2018, Martín Ferrari wrote: > Adrian, > > On 24/08/18 13:47, Adrian Bunk wrote: > > > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/prometheus.html > > > > ... > > panic: Can't start web handler:listen tcp :9090: bind: address already in > > use > > This is a known problem when running the autopkgtests, becasue the > installed package starts the daemon and then the tests fail when trying > to use the same port; but this is not a FTBFS: the build daemons do not > fail to build from source. I think you should lower the severity.
Tincho, if we go that route we would be applying a definition for FTBFS which would be different from everybody else. A FTBFS could be defined as a non-zero exit status from dpkg-buildpackage. If you include the test suite as part of the build, then a failure in the test suite will naturally mean a FTBFS bug, for all purposes. If, as you explain, the tests are not suitable to be run after dh_auto_build, then it follows that they should be disabled from the package build, because we don't want dpkg-buildpackage to exit with error. In such case, just an empty debian/rules target like this: override_dh_auto_test: would do the trick. (But of course disabling only the failing tests would be better). Thanks.
