On 08/24/2018 09:56 AM, Christophe Vu-Brugier wrote:
> Hi Thomas,
> 
> Thank you for upgrading the python-rtslib-fb package but I believe some
> important changes are missing in the new package.
> 
>  * The main repository of python-rtslib-fb is now hosted by the
>    Open-iSCSI organization on GitHub and the latest version there is
>    newer 2.1.fb67 (instead of 2.1.fb66). Here is the URL of the new
>    repo on GitHub:
> 
>      https://github.com/open-iscsi/rtslib-fb/

Hi,

I know about this URL. I prefer to package 2.1.fb66, as this is what
OpenStack gates on.

>  * python-rtslib-fb depends on pyudev since version 2.1.fb60.

Thanks, that's fixed.

>  * Since the configuration directory for python-rtslib-fb
>    is "/etc/rtslib-fb-target" instead of "/etc/target", the "preferred
>    DB root" that contains PR and ALUA information should be updated as
>    well. Otherwise, a crash will happen in targetcli-fb which is also
>    patched on Debian to reflect the change in python-rtslib-fb.
> 
>    
> https://salsa.debian.org/cvubrugier-guest/python-rtslib-fb/commit/f33246d594f1795f89cd9704190f2b2216b9b350

Thanks, I've added your change.

> You can have a look at the changes I pushed a few months ago on my
> repository on Salsa:
> 
>   
> https://salsa.debian.org/cvubrugier-guest/python-rtslib-fb/commits/debian/queens

Could you explain this?
https://salsa.debian.org/cvubrugier-guest/python-rtslib-fb/commit/01763af1f2303d06b127e23a20bb178e1505ac6f

> Please tell me if I can be of any help.

What you've done is very helpful. Thanks!

Cheers,

Thomas Goirand (zigo)

Reply via email to