Control: tags -1 patch Hi Tim,
On Sa 12 Mai 2018 21:57:33 CEST, Tim Düsterhus wrote:
Mike, Am 12.05.2018 um 21:45 schrieb Mike Gabriel:Would you be willing to propose the above upstream? https://github.com/tinyproxy/tinyproxy Help with approaching upstream with above analysis will be highly welcome. If you are not available for this, please let me know, and I will forward the necessary info.I already moved my set-up to another forward proxy, thus *personally* I am not in a need for a bugfix. I created this bug to help other users going forward. I'd prefer if you'd handled the main communication with upstream. If you link an upstream bug report here I'm going to subscribe and chime in if absolutely necessary. I have attached a proof of concept patch for the select(2) issue, which properly reset the rfds array (and for some reason I don't understand also fixes the accept(2) race condition). After applying the patch to tinyproxy 1.8.4-2 (Debian Stretch) I was no longer able to reproduce the issue. This patch is CC-0 licensed, feel free to forward all or parts of my initial bug report or this patch to upstream.
Thanks for the patch. Would you be willing to re-license the patch under GPL-2+ (just like the rest of the tinyproxy code). That would ease things regarding upstream patch submission and acceptance.
Sorry for this very late reply, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: [email protected], http://das-netzwerkteam.de
pgpIJOTnspebD.pgp
Description: Digitale PGP-Signatur
