Bug#904083: Regression run_lintian calls lintian with a non existing filename

[Maximiliano Curia]

Package: sbuild
Version: 0.77.0-3
Severity: important

Hi,


I: schroot -d /<<BUILDDIR>> -c 
unstable-amd64-sbuild-a8e6ff65-a882-41b6-9ce3-b5e764b4ca8c --run-session -q -u maxy -p -- 
lintian -I --pedantic --show-overrides sddm_0.18.0-1_amd64.changes
D: Running command: schroot -d /<<BUILDDIR>> -c 
unstable-amd64-sbuild-a8e6ff65-a882-41b6-9ce3-b5e764b4ca8c --run-session -q -u maxy -p -- 
lintian -I --pedantic --show-overrides sddm_0.18.0-1_amd64.changes
warning: "sddm_0.18.0-1_amd64.changes" cannot be processed.
warning: It is not a valid lab query and it is not an existing file.

E: Lintian run failed (runtime error)



Thanks for working in sbuild. :)

Happy hacking,

-- System Information:
Debian Release: buster/sid
 APT prefers testing-debug
 APT policy: (700, 'testing-debug'), (700, 'testing'), (600, 'stable-updates'), 
(600, 'stable-debug'), (600, 'proposed-updates'), (600, 'stable'), (500, 
'oldstable-updates'), (500, 'oldstable-proposed-updates'), (500, 
'buildd-unstable'), (500, 'oldstable'), (50, 'unstable-debug'), (50, 
'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages sbuild depends on:
ii  adduser         3.117
ii  libsbuild-perl  0.77.0-3
ii  perl            5.26.2-6

Versions of packages sbuild recommends:
ii  autopkgtest  5.4.1
ii  debootstrap  1.0.106
ii  schroot      1.6.10-5

Versions of packages sbuild suggests:
pn  deborphan  <none>
ii  kmod       25-1
ii  wget       1.19.5-1

-- Configuration Files:
/etc/sbuild/sbuild.conf changed:
1;


-- no debconf information

--

-- Edsger W. Dijkstra
Saludos /\/\ /\ >< `/

diff --git a/lib/Sbuild/Build.pm b/lib/Sbuild/Build.pm
index 18c8656c..cf039e91 100644
--- a/lib/Sbuild/Build.pm
+++ b/lib/Sbuild/Build.pm
@@ -2598,8 +2598,8 @@ sub build {
 		rename("$sys_build_dir/$changes.new", "$sys_build_dir/$changes")
 		    or $self->log("$sys_build_dir/$changes.new could not be " .
 		    "renamed to $sys_build_dir/$changes: $!\n");
-		unlink("$build_dir/$changes")
-		    if $build_dir;
+		# unlink("$build_dir/$changes")
+		#     if $build_dir;
 	    }
 
 	    return $pchanges;

With the new release of sbuild 0.77 (which moves the run_lintian call outside of the build function), lintian receives the name of a no longer existing changes file (as the unlink is part of the copy_changes) and as such it fails with, for example: The issue is not present using the 0.76 version, and can be workaround commenting the unlink call from the copy_changes function (as shown in the attached file). "It is not the task of the University to offer what society asks for, but to give what society needs."

signature.asc
Description: PGP signature