On Sun, 2018-06-17 at 18:35 +0000, Niels Thykier wrote: > Drew Parsons: > > > The primary use of DEB_BUILD_MAINT_OPTIONS that I know of is to make > dpkg-buildflags enable hardening or other special-case compiler > flags. > E.g. DEB_BUILD_MAINT_OPTIONS=hardening=+all. > > That use-case is completely handled/covered by dpkg-buildflags.
I see. The idea is that dpkg-buildflags uses DEB_BUILD_MAINT_OPTIONS to adjust CFLAGS and friends. nocheck has no place there. The debhelper check in /usr/share/lintian/checks/rules.pm checks for DEB_BUILD_OPTIONS in debian/rules and issues a warning on it (l.219). An override for that warning is automatically placed if DEB_BUILD_OPTIONS contains nocheck, but only when override_dh_auto_test is used (l.447). I'm not sure if the tests in my upstream build script can be handled with override_dh_auto_test. In that case, I should use a package lintian-override to override the lintian warning. Drew