Control: tags -1 upstream
On 2018-06-07 19:11 +0200, Jakub Wilk wrote:
> Package: libncurses-dev
> Version: 6.1+20180210-4
>
> The compiler flags that are supposedly needed to compile with ncurses
> include feature test macros:
>
> $ ncurses6-config --cflags
> -D_GNU_SOURCE -D_DEFAULT_SOURCE
>
> $ pkg-config --cflags ncurses
> -D_GNU_SOURCE -D_DEFAULT_SOURCE
This has been done upstream in the 20150221 patchlevel:
,----
| + capture define's related to -D_XOPEN_SOURCE from the configure check
| and add those to the *-config and *.pc files, to simplify use for
| the wide-character libraries.
`----
Which raises a few questions, e.g.
- Why is this done even if ncurses is configured without --enable-widec ?
- Why does it end up in tinfo.pc and tic.pc which (presumably) would
never need it?
> Please don't include them.
> _GNU_SOURCE is particularly nasty, because it can change semantics of
> some libc functions (at least sscanf and strerror_r).
I tend to agree, but would rather not deviate from upstream, especially
since this behavior has been in place for over three years already.
Cheers,
Sven
