Quoting Jonas Smedegaard (2018-06-11 17:52:55)
> Quoting Guido Günther (2018-06-11 16:05:46)
> > On Mon, Jun 11, 2018 at 03:52:55PM +0200, Jonas Smedegaard wrote:
> > > Quoting Guido Günther (2018-06-11 15:02:06)
> > > > Hi,
> > > > On Mon, Jun 11, 2018 at 02:10:52PM +0200, Jonas Smedegaard wrote:
> > > > > Quoting Guido Günther (2018-06-11 13:32:34)
> > > > > > Hi,
> > > > > > On Mon, Jun 11, 2018 at 11:59:58AM +0200, Jonas Smedegaard wrote:
> > > > > > > Quoting Guido Günther (2018-06-11 11:07:33)
> > > > > > > > On Mon, Jun 11, 2018 at 11:04:51AM +0200, Guido Günther wrote:
> > > > > > > > > On Mon, Jun 11, 2018 at 10:01:44AM +0200, Jonas Smedegaard 
> > > > > > > > > wrote:
> > > > > > > > > > "gbp import-orig --uscan" seems to choke on tarballs 
> > > > > > > > > > repacked by uscan.
> > > > > > > > > > 
> > > > > > > > > > With the attached debian files - changelog, copyright, and 
> > > > > > > > > > watch, in an freshly created git project (i.e. just "git 
> > > > > > > > > > init"), doing "gbp import-orig --uscan" will succeed but 
> > > > > > > > > > the resulting project wil be missing the subdirectories 
> > > > > > > > > > translations and utils.
> > > > > > > > > > 
> > > > > > > > > > Doing same without the copyright file will have all files 
> > > > > > > > > > imported.
> > > > > > > > > > 
> > > > > > > > > > The repacked tarball do contain the subdirectories, so it 
> > > > > > > > > > seems gbp chokes on it for some reason.
> > > [...]
> > > > > > The tarball generated by uscan "monero_0.12.2.0~dfsg.orig.tar.gz" 
> > > > > > does
> > > > > > not contain the directories you mention. When I run this:
> > > > > > 
> > > > > >     $ git branch upstream
> > > > > >     $ gbp import-orig -v --merge-mode=replace 
> > > > > > --postimport=/bin/true --no-pristine-tar --no-sign --uscan
> > > > > >     … 
> > > > > >     $ DIRS='translations|utils' ; tar -list -af 
> > > > > > monero_0.12.2.0~dfsg.orig.tar.gz | grep -qs -E "(${DIRS})/" || echo 
> > > > > > "${DIRS} not found"
> > > > > >     translations|utils not found
> > > > > > 
> > > > > > Can you show me what I'm missing to reproduce this?
> > > > > 
> > > > > Oh - I use Midnight Commander (package mc) to inspect tarballs, and 
> > > > > apparently that can parse tarballs that tar cannot.
> > > > > 
> > > > > Seems this is an issue of corrupted tarball, then.
> > > > > 
> > > > > I now found a commandline tool that confirms that the dirs exist:  
> > > > > Can 
> > > > > you try confirm by installing package pax and running this command:
> > > > > 
> > > > >   paxtar tvzf monero_0.12.2.0~dfsg.orig.tar.gz '*.ts'
> > > > > 
> > > > > At my end, that outputs the following:
> > > > > 
> > > > > -rw-rw-r--  1 root     root        195575 Jun  3 18:41 
> > > > > monero-0.12.2.0/translations/monero.ts
> > > > > -rw-rw-r--  1 root     root        230673 Jun  3 18:41 
> > > > > monero-0.12.2.0/translations/monero_fr.ts
> > > > > -rw-rw-r--  1 root     root        204343 Jun  3 18:41 
> > > > > monero-0.12.2.0/translations/monero_it.ts
> > > > > -rw-rw-r--  1 root     root        224691 Jun  3 18:41 
> > > > > monero-0.12.2.0/translations/monero_sv.ts
> > > >
> > > > Yeah, I see these with paxtar
> > > 
> > > Good, so I am not dreaming here.  That's progress!
> > > 
> > > 
> > > > but given that dpkg (AFAIK) uses plain tar I wonder if there's a bug 
> > > > here?
> > > 
> > > I see potentially two bugs:
> > > 
> > >  a) Creating a tarball that is unparsable by Debian /bin/tar
> > > 
> > >  b) Wrongly parsing tarball with /bin/tar which other tools can parse.
> > > 
> > > Since git-buildpackage does not create any tarball here (uscan did it), 
> > > I suggest that we reuse this bugreport for b) and create a new bugreport 
> > > for a).
> > > 
> > > 
> > > > Can you dig out what makes these files different and if these are 
> > > > allowed by policy? I tried several of tar's -H options but this did 
> > > > not change anything and did not find anything related in Debian policy 
> > > > either.
> > > 
> > > Sorry, I don't understand your question.  Also, if it relates to a) then 
> > > please wait and I will file a separate bugreport for that.
> > > 
> > > 
> > > > What is monero using to create the tarball? I quick grep in the 
> > > > sources didn't bring anything up.
> > > 
> > > How upstream tarball was created might or might not matter - in any case 
> > > it is related to a), so please let me create another bugreport for that.
> > > 
> > > 
> > > First, do you agree it makes sense to separate a) into another separate 
> > > bugreport?  And discuss only b) here (and possibly reassign to tar)?
> > 
> > Yes. As I read it a) would need to be assigned to uscan (with affects:
> > git-buildpackage) and b) stays with gbp.
> >  -- Guido
> 
> Seems the bug was reported already: 831870
> 
> A workaround is mentioned - I will try if that works here too...

No, workaround seemingly only "worked" by shrinking the tarball to the 
part that didn't get mangled by the broken tar deletion.  Real bug is 
this one: 869087


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: signature

Reply via email to