Hello, Thank for your review.
2018-05-25 9:31 GMT+03:00 Lumin <cdlumin...@gmail.com>: > On Wed, May 23, 2018 at 07:50:57PM +0300, Dmitry Eremin-Solenikov wrote: >> Hello, >> >> I have updated odp & odp-dpdk packages on mentors.d.n. > > Please file another RFS bug for the odp-dpdk package since it is a > different source. Sure, filled #900407. >> 2018-05-06 3:56 GMT+03:00 Dmitry Eremin-Solenikov <dbarysh...@gmail.com>: >> > I will make my next upload use alternatives, thank you. >> >> This upload uses alternatives to select ODP library to be used. > > The package is going in the right way, but the alternatives still needs > to be improved. Thanks. I've updated -dev packages to also use alternatives. > Nitpickings about the updated package: > > 1. README.Debian > "Library packages should contain libodp-linux.so.FOO" > It should be "libodp-linux.so.SOVER", which is more precise. Hmm. I have checked buster package lists. Only blas/lapack packages use soname as virtual package name in provides. The rest of packages use libsomethingSOVER. Wouldn't it be logical to stick to convention used by the rest of packages? > 2. command `dot` comes from graphviz, but it is missing from B-D. Ack, fixed. > > 3. libodp-generic119 should provide libodp-linux.so.119 instead of > libodp-linux119. And applications that need libodp-linux.so.119 > could declare Depends: libodp-linux.so.119 | libodp-generic119 . > > This is similar to libblas.so.3 | libblas3 setting of the BLAS > implementations. See above. > 4. libodp-generic-dev should Privides: libodp-linux.so . > odp-generic/libodp-linux.so should be registered in the alternatives > system to provide a /usr/lib/DEB_HOST_MULTIARCH/libodp-linux.so . > > The static library /usr/lib/x86_64-linux-gnu/libodp-linux.a should > be put to the /.../odp-generic directory, and be registered as a slave > of the libodp-linux.so alternative. > > I also noticed that the symlink points to an invalid path. > Please solve this issue by the alternatives system as said above. > > root@bfb95763d3d6 ~/odp-1.19.0.1# ll > /usr/lib/x86_64-linux-gnu/libodp-linux.so > lrwxrwxrwx 1 root root 23 May 23 16:01 > /usr/lib/x86_64-linux-gnu/libodp-linux.so -> libodp-linux.so.119.0.1 > > libblas3 and libopenblas-base and their corresponding -dev packages are > good examples at this point. If you have doubts, you can carefully > examine these packages which may possibly provide help. I have fixed alternatives usage for -dev packages (and removed Conflicts entry in d/contron and README.Debian files). > Please ping me if you have question, or ready for the next round of > review :-) New packages are uploaded to mentors.d.n. Hopefully with this upload I will have just two remaining issues: - manpages - dh_auto_test override. I plan to look onto adding package autotests afterwards. -- With best wishes Dmitry
