Package: pdf-presenter-console
Version: 4.1.2-1
Severity: important
Hello,
I've just tested pdf-presenter-console/4.1.2-1 from Debian unstable.
It seems to fix bug #888677, as intended.
However, it appears to have a major regression (maybe caused by
collateral damage of the fix for bug #888677 ?!?): it no longer
recognizes movies in PDF pages. They are no longer clickable
in the presenter screen or in the audience screen.
Downgrading to pdf-presenter-console/4.1-4 makes movies work again.
I could even argue that this regression is big enough to justify a
"grave" severity for this bug report, as I think pdf-presenter-console
should not migrate to Debian testing after losing the really useful
movie-playing feature! It would be major step back!
Please raise the severity, if you agree with my reasoning.
Please forward this bug report upstream as soon as possible,
and/or revert the upstream change that introduced this regression.
Thanks for your time!
P.S.: after taking a look at the code, I wonder whether the regression
is maybe caused by the fact that, in file
pdfpc/src/classes/metadata/pdf.vala ,
the "page.remove_annot(a);" line has been added outside the
switch block:
List<Poppler.AnnotMapping> anns = page.get_annot_mapping();
foreach(unowned Poppler.AnnotMapping am in anns) {
var a = am.annot;
switch (a.get_annot_type()) {
case Poppler.AnnotType.TEXT:
case Poppler.AnnotType.FREE_TEXT:
case Poppler.AnnotType.HIGHLIGHT:
case Poppler.AnnotType.UNDERLINE:
case Poppler.AnnotType.SQUIGGLY:
if (note_text.length > 0) {
note_text += "\n";
}
note_text += a.get_contents();
break;
}
// Remove the annotation to avoid its rendering
page.remove_annot(a);
}
This means that, maybe, all annotations are removed, including
SCREEN and MOVIES ones, which should instead be preserved for
movie playing support... ?!?
Should the "page.remove_annot(a);" line be moved between
"note_text += a.get_contents();" and "break;", perhaps?
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.16.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages pdf-presenter-console depends on:
ii libatk1.0-0 2.28.1-1
ii libc6 2.27-3
ii libcairo-gobject2 1.15.10-3
ii libcairo2 1.15.10-3
ii libfribidi0 0.19.7-2
ii libgdk-pixbuf2.0-0 2.36.11-2
ii libgee-0.8-2 0.20.1-1
ii libglib2.0-0 2.56.1-2
ii libgstreamer-plugins-base1.0-0 1.14.0-2
ii libgstreamer1.0-0 1.14.0-1
ii libgtk-3-0 3.22.29-3
ii libpango-1.0-0 1.42.0-1
ii libpangocairo-1.0-0 1.42.0-1
ii libpoppler-glib8 0.63.0-2
ii libx11-6 2:1.6.5-1
Versions of packages pdf-presenter-console recommends:
ii gstreamer1.0-gtk3 1.14.0-4
pdf-presenter-console suggests no packages.
-- no debconf information
