Control: forwarded -1 https://github.com/grnet/ganeti-os-noop/pull/8

Hi Bastian

On  Fr 13 Apr 2018 11:59:14 CEST, Bastian Blank wrote:

Package: ganeti-os-noop
Version: 0.2-1
Severity: grave

The export script tries to use blockdev to check for the size.  This
works fine for block devices, but completely fails for everything else.
As this script also ignores the error, the export fails with a
completely non-discriptive output.

| 2018-04-13 09:40:12,803: blockdev: ioctl error on BLKGETSIZE64: Inappropriate ioctl for device
| 2018-04-13 09:40:12,805: dd: 0 bytes copied, 0.00124913 s, 0.0 kB/s

The fix is to use "stat" in case of non block devices:
| if test -n "$EXP_SIZE_FD"; then
|   if [ -f "$EXPORT_DEVICE" ]; then
|     stat -c '%s' "$EXPORT_DEVICE" >&"$EXP_SIZE_FD"
|   else
|     blockdev --getsize64 "$EXPORT_DEVICE" >&"$EXP_SIZE_FD"
|   fi
| fi

I fixed this in unstable now.

Please fix this in stable also.

The preparation of an s-pu is on my list for the coming week (we'll see...).

I also forwarde the patch upstream:
https://github.com/grnet/ganeti-os-noop/pull/8

Please cross-check that everything is alright the way I did. Thanks!

Greets,
Mike
--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

Attachment: pgpL5iRoKJqxE.pgp
Description: Digitale PGP-Signatur

Reply via email to