Source: intel-ipsec-mb
Version: 0.49-1.1
Severity: normal
Tags: patch

Please change packaging of intel-ipsec-mb to install headers and library
into system path. For example latest DPDK master expects to find
intel-ipsec-mb.h/-lIPSec_MB without any additional flags.

Also statically linked library (libIPSec_MB.a) should go to -dev
package, rather than library package itself.

I'm attaching proposed packaging changes.

-- 
With best wishes
Dmitry

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Napur old/intel-ipsec-mb-0.49/debian/changelog 
intel-ipsec-mb-0.49/debian/changelog
--- old/intel-ipsec-mb-0.49/debian/changelog    2018-04-03 16:24:59.000000000 
+0300
+++ intel-ipsec-mb-0.49/debian/changelog        2018-04-24 12:56:31.673744583 
+0300
@@ -1,3 +1,13 @@
+intel-ipsec-mb (0.49-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Install libraries and headers into system path.
+  * Rename library package to follow soname.
+  * Use dh_installdocs to install LICENSE file.
+  * Install README file.
+
+ -- Dmitry Eremin-Solenikov <dbarysh...@gmail.com>  Tue, 24 Apr 2018 12:56:30 
+0300
+
 intel-ipsec-mb (0.49-1) unstable; urgency=medium
 
   * Sync to latest 0.49 release, drop debian/patches that are
diff -Napur old/intel-ipsec-mb-0.49/debian/control 
intel-ipsec-mb-0.49/debian/control
--- old/intel-ipsec-mb-0.49/debian/control      2018-03-01 16:42:57.000000000 
+0300
+++ intel-ipsec-mb-0.49/debian/control  2018-04-24 12:50:46.935049569 +0300
@@ -7,7 +7,7 @@ Build-Depends: debhelper (>= 11), nasm
 Standards-Version: 4.1.2
 Homepage: https://github.com/intel/intel-ipsec-mb
 
-Package: libipsec-mb
+Package: libipsec-mb0
 Section: libs
 Architecture: amd64
 Priority: optional
@@ -22,7 +22,7 @@ Package: libipsec-mb-dev
 Section: libdevel
 Architecture: linux-amd64
 Priority: optional
-Depends: ${misc:Depends}, libipsec-mb
+Depends: ${misc:Depends}, libipsec-mb0 (= ${binary:Version})
 Pre-Depends: ${misc:Pre-Depends}
 Description: Development files for Intel(R) Multi-Buffer Crypto for IPSec 
library
  Libipsec-mb is highly-optimized software implementations of
diff -Napur old/intel-ipsec-mb-0.49/debian/libipsec-mb0.docs 
intel-ipsec-mb-0.49/debian/libipsec-mb0.docs
--- old/intel-ipsec-mb-0.49/debian/libipsec-mb0.docs    1970-01-01 
03:00:00.000000000 +0300
+++ intel-ipsec-mb-0.49/debian/libipsec-mb0.docs        2018-04-24 
12:53:12.598153081 +0300
@@ -0,0 +1,2 @@
+LICENSE
+README
diff -Napur old/intel-ipsec-mb-0.49/debian/libipsec-mb0.install 
intel-ipsec-mb-0.49/debian/libipsec-mb0.install
--- old/intel-ipsec-mb-0.49/debian/libipsec-mb0.install 1970-01-01 
03:00:00.000000000 +0300
+++ intel-ipsec-mb-0.49/debian/libipsec-mb0.install     2018-04-24 
12:54:58.805836161 +0300
@@ -0,0 +1 @@
+usr/lib/*/libIPSec_MB.so.*
diff -Napur old/intel-ipsec-mb-0.49/debian/libipsec-mb-dev.install 
intel-ipsec-mb-0.49/debian/libipsec-mb-dev.install
--- old/intel-ipsec-mb-0.49/debian/libipsec-mb-dev.install      2018-03-15 
21:59:42.000000000 +0300
+++ intel-ipsec-mb-0.49/debian/libipsec-mb-dev.install  2018-04-24 
12:46:25.371843168 +0300
@@ -1,3 +1,4 @@
-usr/include/intel-ipsec-mb/*
+usr/include/*
+usr/lib/*/libIPSec_MB.a
+usr/lib/*/libIPSec_MB.so
 usr/share/man/man7/*
-
diff -Napur old/intel-ipsec-mb-0.49/debian/libipsec-mb.install 
intel-ipsec-mb-0.49/debian/libipsec-mb.install
--- old/intel-ipsec-mb-0.49/debian/libipsec-mb.install  2018-02-15 
13:34:15.000000000 +0300
+++ intel-ipsec-mb-0.49/debian/libipsec-mb.install      1970-01-01 
03:00:00.000000000 +0300
@@ -1,2 +0,0 @@
-usr/share/doc/libipsec-mb/LICENSE
-usr/lib/intel-ipsec-mb/*
diff -Napur old/intel-ipsec-mb-0.49/debian/libipsec-mb.lintian-overrides 
intel-ipsec-mb-0.49/debian/libipsec-mb.lintian-overrides
--- old/intel-ipsec-mb-0.49/debian/libipsec-mb.lintian-overrides        
2018-03-01 16:42:57.000000000 +0300
+++ intel-ipsec-mb-0.49/debian/libipsec-mb.lintian-overrides    1970-01-01 
03:00:00.000000000 +0300
@@ -1 +0,0 @@
-libipsec-mb: package-has-unnecessary-activation-of-ldconfig-trigger
diff -Napur old/intel-ipsec-mb-0.49/debian/rules 
intel-ipsec-mb-0.49/debian/rules
--- old/intel-ipsec-mb-0.49/debian/rules        2018-04-03 16:24:59.000000000 
+0300
+++ intel-ipsec-mb-0.49/debian/rules    2018-04-24 12:53:28.366089937 +0300
@@ -1,8 +1,10 @@
 #!/usr/bin/make -f
 
+include /usr/share/dpkg/architecture.mk
+
 DESTDIR=$$(pwd)/debian/tmp
-LIBDIR=/usr/lib/intel-ipsec-mb
-HDRDIR=/usr/include/intel-ipsec-mb
+LIBDIR=/usr/lib/$(DEB_HOST_MULTIARCH)
+HDRDIR=/usr/include
 MANDIR=/usr/share/man/man7
 
 VERSION_MAJOR=$(shell grep "^VERSION = " Makefile | tr '.' ' ' | cut -d' ' -f3)
@@ -11,11 +13,6 @@ VERSION_MINOR=$(shell grep "^VERSION = "
 MAN1 = libipsec-mb.7
 MAN2 = libipsec-mb-dev.7
 
-#
-# DOCDIR is the same path as the library copyright file
-#
-DOCDIR=/usr/share/doc/libipsec-mb
-
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk
@@ -26,10 +23,6 @@ override_dh_auto_build:
        $(shell dpkg-buildflags --export=sh); SHARED=n dh_auto_build
 
 override_dh_auto_install:
-       # Documentation
-       install -d ${DESTDIR}${DOCDIR}
-       install -m 0644 $$(pwd)/LICENSE ${DESTDIR}${DOCDIR}
-
        # Install the library
        install -d ${DESTDIR}${LIBDIR}
        install -m 0644 -s $$(pwd)/libIPSec_MB.a ${DESTDIR}${LIBDIR}

Reply via email to