tags 894759 + pending thanks On Tue, Apr 03, 2018 at 02:56:59PM -0700, Filipe Brandenburger wrote:
> When networking.service's ExecStartPre is not supposed to do anything
> (for instance, when CONFIGURE_INTERFACES=no is set, or when `ifquery
> --read-environment --list --exclude=lo` returns an empty list, then the
> ExecStartPre will show with a (code=exited, status=1/FAILURE) in the
> `systemctl status networking.service` output.
>
> That doesn't really cause any failures, but is misleading, since there's
> nothing necessarily wrong with that condition.
>
> I suggest using an "if" instead of "&&" on that line, so that it still
> exits 0 if there's nothing to do.
Thanks, I applied your patch, it will be part of the next release!
--
Met vriendelijke groet / with kind regards,
Guus Sliepen <[email protected]>
signature.asc
Description: PGP signature
