Package: auto-apt-proxy
Version: 8
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu bionic ubuntu-patch autopkgtest
Hi Antonio,
The autopkgtests for auto-apt-proxy 8 have been failing in Ubuntu because
they assume that installing apt-cacher-ng is sufficient to cause apt to use
it for apt downloads:
[...]
autopkgtest [03:00:15]: test apt-integration: [-----------------------
Reading package lists...
NOTICE: 'auto-apt-proxy' packaging is maintained in the 'Git' version control sy
stem at:
https://anonscm.debian.org/git/users/terceiro/auto-apt-proxy.git
Please use:
git clone https://anonscm.debian.org/git/users/terceiro/auto-apt-proxy.git
to retrieve the latest (possibly unreleased) updates to the package.
Need to get 17.1 kB of source archives.
Get:1 http://ftpmaster.internal/ubuntu bionic-proposed/universe auto-apt-proxy 8
(dsc) [1786 B]
Get:2 http://ftpmaster.internal/ubuntu bionic-proposed/universe auto-apt-proxy 8
(tar) [15.3 kB]
dpkg-source: info: extracting auto-apt-proxy in auto-apt-proxy-8
dpkg-source: info: unpacking auto-apt-proxy_8.tar.xz
Fetched 17.1 kB in 0s (932 kB/s)
autopkgtest [03:00:16]: test apt-integration: -----------------------]
autopkgtest [03:00:16]: test apt-integration: - - - - - - - - - - results - - -
- - - - - - -
apt-integration FAIL non-zero exit status 1
[...]
http://autopkgtest.ubuntu.com/packages/a/auto-apt-proxy/bionic/amd64
The failing part of the test is the grep for auto-apt-proxy in
/var/log/apt-cacher-ng/apt-cacher.log. The reason this grep returns no
results is that the Ubuntu autopkgtest environment sets a no_proxy variable
which matches the configured apt mirrors; therefore, apt-cacher-ng's
configuration has no effect because apt rightly bypasses it according to the
environment setting.
The attached patch allows the auto-apt-proxy autopkgtest to pass by making
it a no-op when $no_proxy is present. You might prefer instead to unset it
and run the test, but in that case apt-cacher-ng must itself honor the
no_proxy setting, which it may or may not do.
Please consider including this or a similar patch in Debian.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru auto-apt-proxy-8/debian/tests/apt-integration
auto-apt-proxy-8ubuntu1/debian/tests/apt-integration
--- auto-apt-proxy-8/debian/tests/apt-integration 2017-11-27
07:50:22.000000000 -0800
+++ auto-apt-proxy-8ubuntu1/debian/tests/apt-integration 2018-03-19
16:40:51.000000000 -0700
@@ -2,6 +2,11 @@
set -eu
+if -n [ "$no_proxy" ]; then
+ echo "no_proxy variable is set, skipping test"
+ exit 0
+fi
+
cd ${AUTOPKGTEST_TMP:-/tmp}
apt-get source auto-apt-proxy
