Control: tags -1 patch
On Wed, Feb 28, 2018 at 11:26:22AM +0100, Andreas Tille wrote:
>...
> I know that ClonalFrame is not really supported any more but due to
> Debian usage statistics it has some permanent users we woul love to
> support with working code. It seems that a change in glibc has
> uncovered some code that is not properly using OVERFLOW and UNDERFLOW
> definitions (see below).
The code was not used, which also explains why noone noticed.
Trivial fix to comment it out is attached.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
Description: Comment out Util::lBinoProb()
The code didn't make sense, causes FTBFS with glibc >= 2.27 and was unused.
Author: Adrian Bunk <[email protected]>
Bug-Debian: https://bugs.debian.org/891335
--- clonalframe-1.2.orig/src/util.cpp
+++ clonalframe-1.2/src/util.cpp
@@ -93,6 +93,7 @@ fclose(f);
}
+#if 0
double Util::lBinoProb (int i,int n, double p)
/*returns the prob of i successes in n trials with prob of sucess p.*/
{
@@ -149,6 +150,7 @@ fclose(f);
return logsum;
}
+#endif /* 0 */
double Util::lbetapdf(double x,double a,double b)
--- clonalframe-1.2.orig/src/util.h
+++ clonalframe-1.2/src/util.h
@@ -56,7 +56,7 @@ namespace wb {
static void normalize(gsl_vector * v);
static void normalize(double *v,int size);
static int vecsum_char(gsl_vector_char * vec);
- static double lBinoProb (int i,int n, double p);
+ //static double lBinoProb (int i,int n, double p);
static double lbetapdf(double x,double a,double b);
static double mylgamma(double z);
static double LDirichletProb(double prior[],double post[],int length);
