Reinhard Tartler wrote:

Thank you very much for your bugreport and your patch.

We are currently preparing an upload for 0.4.7-4, you can look at our
current process here:
http://svn.debian.org/wsvn/pkg-wpa/trunk/wpasupplicant/?rev=0&sc=0

Parts of your patch are already included there, I will look if anything
is missing. The svn should already be lintian clean.

Thanks again,
        Reinhard.


I interigated the svn working copy (revision 50 of pkg-wpa) just now.

01_install-changelog-improvement.patch
Resending the patch to install the upstream changelog properly, it requires less code, and you don't have to clean it up with a mv command.

I really do not understand what you are doing with the init script. Why even bother to install it to /etc/init.d/ when it is not even registered with update-rc.d? Why install it manually? (dh_installinit probably does not like installing it there without calling update-rc.d perhaps) Would /usr/sbin not be a more appripriate place? Won't this permanently change the way debian-users use this package?

Also, the lintian override file is growing!

In the postinst script, all the symlinks in runlevels are purged, but then invoke-rc.d starts wpasupplicant, why?

The postrm removes non-existant symlinks . . .

Can you please explain a little about how the end user will use this package now? What is the rough roadmap for this package (planned future changes)? Maybe then I will understand the current changes better, and can begin helping you with them instead of asking a million questions :-)

Thanks, Kel.
diff -Nru wpasupplicant.orig/debian/rules wpasupplicant/debian/rules
--- wpasupplicant.orig/debian/rules	2006-02-20 21:14:30.000000000 +1000
+++ wpasupplicant/debian/rules	2006-02-20 21:33:53.403730936 +1000
@@ -66,11 +66,9 @@
 	dh_testdir 
 	dh_testroot
 	dh_installexamples
-	dh_installchangelogs
+	dh_installchangelogs ChangeLog
 	dh_installman
 	dh_installdocs
-	mv debian/wpasupplicant/usr/share/doc/wpasupplicant/ChangeLog \
-	   debian/wpasupplicant/usr/share/doc/wpasupplicant/changelog
 	dh_strip
 	dh_link
 	dh_compress
diff -Nru wpasupplicant.orig/debian/wpasupplicant.docs wpasupplicant/debian/wpasupplicant.docs
--- wpasupplicant.orig/debian/wpasupplicant.docs	2006-02-20 21:14:30.000000000 +1000
+++ wpasupplicant/debian/wpasupplicant.docs	1970-01-01 10:00:00.000000000 +1000
@@ -1 +0,0 @@
-ChangeLog

Reply via email to