Control: tag -1 pending
Hello Balint,
Balint Reczey [2017-05-04 2:07 +0200]:
> - create_command = 'dpkg-source -x "%s"' % dsc_tb
> + create_command = 'dpkg-source -x "%s" src' % dsc_tb
That's a good idea.
> @@ -385,10 +385,10 @@ def build_source(kind, arg, built_binaries):
> ' ver=${srcversion:-$pkg_candidate};'
> ' dpkg --compare-versions "$ver" lt "$maxver" ||
> maxver="$ver";'
> 'done;'
> - '[ -z "$maxver" ] || maxver="=$maxver";'
> + '[ -z "$maxver" ] || maxver="$maxver";'
This is now a no-op.
> - 'OUT=$(apt-get source -q --only-source
> %(src)s$maxver 2>&1) || RC=$?;'
> + 'OUT=$(apt-get source -d -q --only-source
> %(src)s=$maxver 2>&1) || RC=$?;'
This breaks (or is at least unintuitive) if $maxver is empty.
> 'if [ -n "$RC" ]; then if echo "$OUT" | grep -q
> "Unable to find a source package"; then exit 1; else exit $RC; fi; fi;'
> - 'echo "$OUT" | grep ^Get: || true' % {'src': arg})
> + 'echo "$OUT" | grep ^Get: ; dpkg-source -x
> %(src)s_$maxver.dsc src' % {'src': arg})
I now implemented this idea in
https://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/commit/?id=762397342b
but without the $maxver changes.
Thanks!
Martin
