Package: rinse
Version: 3.2
When downloading packages, Wget's exit was ignored. This leads to errors
later on that may mask the underlying cause.
The attached patch reports Wget errors and exits.
Note that this may still lead to 0-byte RPM files lying around; I have made
no attempt to clean them up, as I do not care about them.
Regards,
Ulrich
From 60cac919ea2023307ff8d9afc49664b497064304 Mon Sep 17 00:00:00 2001
From: Ulrich Zehl <ulrich-deb...@topfen.net>
Date: Wed, 20 Sep 2017 12:18:44 +0200
Subject: [PATCH] Exit if downloading packages failed
---
bin/rinse | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/bin/rinse b/bin/rinse
index b7d37c5..9287ff1 100755
--- a/bin/rinse
+++ b/bin/rinse
@@ -841,6 +841,13 @@ sub downloadPackagesToDirectory {
# download - unless already present.
system("wget --quiet -O $dir/$key $links{ $key }") unless -e "$dir/$key";
+ if ( $? == -1 ) {
+ print "Failed to execute Wget for $package\n";
+ exit;
+ } elsif ( $? >> 8 > 0 ) {
+ print "Wget failed with exit code " . ( $?>>8 ) . " for $package\n";
+ exit;
+ }
next PACKAGE;
}
print "[Harmless] Failed to find download link for $package\n";
--
2.7.4
