Package: jack
Version: 3.1.1+cvs20050801-1
Severity: minor
Tags: patch
This is what I get when I randomly press Ctrl-C during ripping:
(-) SPACE:1.60GB waiting_WAVs:01 DAE:1+0 ENC:0+1 errors: 15 :-[
Traceback (most recent call last):
File "/usr/bin/jack", line 235, in ?
global_error = jack_main_loop.main_loop(mp3s_todo, wavs_todo, space, dae_queue,
enc_queue, track1_offset)
File "/usr/lib/python2.3/site-packages/jack_main_loop.py", line 216, in
main_loop
x =
i['file'].read()
ValueError: I/O operation on closed file
*warning* abnormal exit
zsh: exit 1 jack
1815:[EMAIL PROTECTED]: ~/tmp/jack]
jack catches ValueError already in one place, but it needs to do the same in
two other cases.
diff -urN jack-3.1.1+cvs20050801~/jack_main_loop.py
jack-3.1.1+cvs20050801/jack_main_loop.py
--- jack-3.1.1+cvs20050801~/jack_main_loop.py 2006-02-14 01:13:10.000000000
+0000
+++ jack-3.1.1+cvs20050801/jack_main_loop.py 2006-02-14 01:13:42.000000000
+0000
@@ -215,7 +215,7 @@
if os.uname()[0] == "Linux" and i['type'] != "image_reader":
try:
x = i['file'].read()
- except IOError:
+ except (IOError, ValueError):
pass
else:
read_chars = 0
@@ -223,7 +223,7 @@
while read_chars <
jack_helpers.helpers[i['prog']]['status_blocksize']:
try:
xchar = i['file'].read(1)
- except IOError:
+ except (IOError, ValueError):
break
x = x + xchar
read_chars = read_chars + 1
@@ -263,9 +263,7 @@
x = ""
try:
x = exited_proc['file'].read()
- except IOError:
- pass
- except ValueError:
+ except (IOError, ValueError):
pass
exited_proc['buf'] = (exited_proc['buf'] +
x)[-jack_helpers.helpers[exited_proc['prog']]['status_blocksize']:]
exited_proc['file'].close()
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Versions of packages jack depends on:
ii cdda2wav 4:2.01+01a03-5 Creates WAV files from audio CDs
ii cdparanoia 3a9.8-11 An audio extraction tool for sampl
ii flac 1.1.2-3+b1 Free Lossless Audio Codec - comman
ii python 2.3.5-3 An interactive high-level object-o
ii python-cddb 1.4-4 Python interface to CD-IDs and Fre
ii python-eyed3 0.6.8-1 Python module for id3-tags manipul
ii python-flac 0.0.4-1 Free Lossless Audio Codec [Python
ii python-pyvorbis 1.3-1 A Python interface to the Ogg Vorb
ii vorbis-tools 1.1.1-1 several Ogg Vorbis tools
jack recommends no packages.
-- no debconf information
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
