Control: tag -1 + patch

On Sun, 18 Jun 2017 23:13:09 +0300, Niko Tyni wrote:

> It looks like the underlying failure reason is that 
> at least filter/tv_to_latex and filter/tv_to_text have
> 
>  use POSIX 'tmpnam';
> 
> which was deprecated in Perl 5.24 and removed in 5.26. Unfortunately
> the deprecation warning apparently went unnoticed earlier as the build
> system hides it.

It looks like POSIX::tmpnam is use()ed but never used, so just
removing the lines shoud be enough.

Trivial patch attached.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Mark Knopfler: Prairie Wedding
diff -Nru xmltv-0.5.69/debian/changelog xmltv-0.5.69/debian/changelog
--- xmltv-0.5.69/debian/changelog	2017-01-24 18:00:06.000000000 +0100
+++ xmltv-0.5.69/debian/changelog	2017-06-30 01:33:35.000000000 +0200
@@ -1,3 +1,12 @@
+xmltv (0.5.69-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "FTBFS with Perl 5.26: t/test_filters.t failure":
+    add posix-tmpnam.patch which removes "use POSIX 'tmpnam'".
+    (Closes: #865045)
+
+ -- gregor herrmann <[email protected]>  Fri, 30 Jun 2017 01:33:35 +0200
+
 xmltv (0.5.69-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru xmltv-0.5.69/debian/patches/posix-tmpnam.patch xmltv-0.5.69/debian/patches/posix-tmpnam.patch
--- xmltv-0.5.69/debian/patches/posix-tmpnam.patch	1970-01-01 01:00:00.000000000 +0100
+++ xmltv-0.5.69/debian/patches/posix-tmpnam.patch	2017-06-30 01:33:35.000000000 +0200
@@ -0,0 +1,27 @@
+Description: drop "POSIX 'tmpnam'"
+ removed in perl 5.26, and actually unused
+Origin: vendor
+Bug-Debian: https://bugs.debian.org/865045
+Author: gregor herrmann <[email protected]>
+Last-Update: 2017-06-30
+
+--- a/filter/tv_to_latex
++++ b/filter/tv_to_latex
+@@ -37,7 +37,6 @@
+ use strict;
+ use XMLTV::Version '$Id: tv_to_latex,v 1.18 2014/05/05 16:02:53 bilbo_uk Exp $ ';
+ use IO::File;
+-use POSIX 'tmpnam';
+ use Getopt::Long;
+ 
+ # Use Log::TraceMessages if installed.
+--- a/filter/tv_to_text
++++ b/filter/tv_to_text
+@@ -34,7 +34,6 @@
+ use XMLTV::Version '$Id: tv_to_text,v 1.8 2015/06/08 17:41:14 stefanb2 Exp $ ';
+ use IO::File;
+ use Date::Manip;
+-use POSIX 'tmpnam';
+ use Getopt::Long;
+ 
+ BEGIN {
diff -Nru xmltv-0.5.69/debian/patches/series xmltv-0.5.69/debian/patches/series
--- xmltv-0.5.69/debian/patches/series	2017-01-24 18:00:06.000000000 +0100
+++ xmltv-0.5.69/debian/patches/series	2017-06-30 01:33:35.000000000 +0200
@@ -2,3 +2,4 @@
 11_makefile_pl_debian_changes.diff
 autopkgtest.patch
 spelling-error-in-manpage.patch
+posix-tmpnam.patch

Attachment: signature.asc
Description: Digital Signature

Reply via email to