Am 19.05.2017 um 23:23 schrieb Chris Lamb: > tags 862593 + patch > thanks > > The archive gets overwritten as the test to see whether it already exists > (to determine whether to create a new one or simply add a new file) uses > an escaped path. > > Patch attached.
I came to a similar conclusion but I wondered whether the real issue is the wrongly escaped path. I think this issue is related to #697493 where it was found that archives with spaces could not be created. I tried to fix bug #862593 by modifying line 372 in src/window.c in the xa_open_archive function. archive[current_page]->escaped_path = xa_escape_bad_chars (archive[current_page]->path,"$\'`\"\\!?* ()&|@#:;"); My solution was to change the line to archive[current_page]->escaped_path = g_strdup(path); This worked for all archives with special characters except the one mentioned in this bug report with backslash and spaces. I think escaping backslashes and spaces is not handled correctly somewhere in the code but I have just briefly tested your patch and it seems to do the trick. Chris, could you cancel the NMU? I do the upload today after I have done some more tests and credit you in the changelog. Thanks for the patch! Regards, Markus
signature.asc
Description: OpenPGP digital signature
