Source: ironic
Version: 1:6.2.0-3
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: buildpath
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that ironic could not be built reproducibly.

This is because you manually remove search.html which, in-turn,
means that dh-sphinx's cruft remover does not consider the 
debian/ironic-doc/usr/share/doc/ironic-doc/*/ subdirs to be Sphinx documentation
and thus it doesn't clear up the cruft.

Patch attached that manually removes the .doctree directories
manually. As you suggest in debian/rules, fixing the underlying problem
that made you remove search.html manually would be the best fix.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/debian/rules      2017-05-05 12:30:14.194783603 +0200
--- b/debian/rules      2017-05-05 14:10:41.066863582 +0200
@@ -67,9 +67,11 @@
        mkdir -p 
$(CURDIR)/debian/ironic-doc/usr/share/doc/ironic-doc/dev-doc-html/_static
        touch 
$(CURDIR)/debian/ironic-doc/usr/share/doc/ironic-doc/dev-doc-html/_static/toggle.js
        rm 
$(CURDIR)/debian/ironic-doc/usr/share/doc/ironic-doc/dev-doc-html/search.html
+       rm -rf 
$(CURDIR)/debian/ironic-doc/usr/share/doc/ironic-doc/dev-doc-html/.doctrees
 
        PYTHONPATH=$(CURDIR) sphinx-build -a -b html install-guide/source 
$(CURDIR)/debian/ironic-doc/usr/share/doc/ironic-doc/install-guide-html
        rm 
$(CURDIR)/debian/ironic-doc/usr/share/doc/ironic-doc/install-guide-html/search.html
+       rm -rf 
$(CURDIR)/debian/ironic-doc/usr/share/doc/ironic-doc/install-guide-html/.doctrees
 
        dh_sphinxdoc -O--buildsystem=python_distutils
 endif

Reply via email to