On Sun, 2017-03-12 at 19:08 +0000, Ghislain Vaillant wrote:
> On 11/03/17 22:47, Ghislain Vaillant wrote:
> > On Sat, 2017-03-11 at 21:47 +0100, Santiago Vila wrote:
> > > BTW: The ri-li package used to fail 95% of the time in my autobuilders
> > > and also "often" in reproducible builds autobuilders. Somebody found
> > > a way to make this failure rate to decrease dramatically, maybe
> > > it may give you a hint.
> > 
> > Could you point me to the specific commit or portion of the discussion
> > where the fix is described, please? I'd be happy to prepare a debdiff
> > for you to apply to check whether this fix you mention works with
> > src:python-qtpy.
> 
> The only recent commit from src:ri-li that looks applicable to
> src:python-qtpy is the use of the additional `-a` flag for the
> xvfb-run calls. I can apply it and provide you with a debdiff.

Hi Santiago,

Could you try the following debdiff, please?

Thanks,
Ghis
diff -Nru python-qtpy-1.2.1/debian/changelog python-qtpy-1.2.1/debian/changelog
--- python-qtpy-1.2.1/debian/changelog	2017-01-22 08:09:05.000000000 +0000
+++ python-qtpy-1.2.1/debian/changelog	2017-03-13 09:23:53.000000000 +0000
@@ -1,3 +1,12 @@
+python-qtpy (1.2.1-2) unstable; urgency=medium
+
+  * Call xvfb-run with the -a option.
+    Reason: fixes random segfaults happening during the tests
+    Thanks to Santiago Vila for reporting (Closes: #854496)
+  * Run autopkgtests for all supported Python versions
+
+ -- Ghislain Antony Vaillant <ghisv...@gmail.com>  Mon, 13 Mar 2017 09:23:53 +0000
+
 python-qtpy (1.2.1-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru python-qtpy-1.2.1/debian/rules python-qtpy-1.2.1/debian/rules
--- python-qtpy-1.2.1/debian/rules	2017-01-22 08:09:05.000000000 +0000
+++ python-qtpy-1.2.1/debian/rules	2017-03-13 09:23:53.000000000 +0000
@@ -12,5 +12,5 @@
 
 override_dh_auto_test:
 ifeq (,$(findstring nocheck,$(DEB_BUILD_PROFILES)))
-	xvfb-run dh_auto_test
+	xvfb-run -a dh_auto_test
 endif
diff -Nru python-qtpy-1.2.1/debian/tests/control python-qtpy-1.2.1/debian/tests/control
--- python-qtpy-1.2.1/debian/tests/control	2017-01-22 08:09:05.000000000 +0000
+++ python-qtpy-1.2.1/debian/tests/control	2017-03-13 09:23:53.000000000 +0000
@@ -1,5 +1,25 @@
-Test-Command: cp -a ./qtpy/tests $AUTOPKGTEST_TMP ; cd $AUTOPKGTEST_TMP ; xvfb-run py.test
-Depends: python-qtpy, python-pytest, xauth, xvfb
+Test-Command: set -e
+ ; cp -r qtpy/tests "$AUTOPKGTEST_TMP"
+ ; for py in $(pyversions -r 2>/dev/null)
+ ; do cd "$AUTOPKGTEST_TMP"
+ ; echo "Testing with $py:"
+ ; xvfb-run -a $py -m pytest -v
+ ; done
+Depends: python-all,
+         python-qtpy,
+         python-pytest,
+         xauth,
+         xvfb
 
-Test-Command: cp -a ./qtpy/tests $AUTOPKGTEST_TMP ; cd $AUTOPKGTEST_TMP ; xvfb-run py.test-3
-Depends: python3-qtpy, python3-pytest, xauth, xvfb
+Test-Command: set -e
+ ; cp -r qtpy/tests "$AUTOPKGTEST_TMP"
+ ; for py in $(py3versions -r 2>/dev/null)
+ ; do cd "$AUTOPKGTEST_TMP"
+ ; echo "Testing with $py:"
+ ; xvfb-run -a $py -m pytest -v
+ ; done
+Depends: python3-all,
+         python3-qtpy,
+         python3-pytest,
+         xauth,
+         xvfb

Reply via email to