Hi Kevin, On Mon, Feb 27, 2017 at 11:43:03AM -0700, Kevin Locke wrote: > On Mon, 2017-02-27 at 12:10 +0100, Guido Günther wrote: > > On Mon, Feb 27, 2017 at 01:00:27AM -0700, Kevin Locke wrote: > >> The second issue is that --git-pbuilder-options is ignored when using > >> --git-builder without --git-pbuilder. Attached patch 0002 fixes this by > > > > You mean "--git-pbuilder-options without --git-pbuilder" ? > > Yes indeed. Good read. > > >> setting the pbuilder environment variables whenever the corresponding > >> option is configured. I think this is reasonable/expected, but if there > >> is a reason that these shouldn't be set, updating the man page to make > >> it clear which options are ignored when --git-pbuilder could be > >> workable. > > > > I've fixed that in the docs since we don't want to interfere with > > people's --git-builder setups. > > That'll work, thanks. The manpage update looks good. I'd update the > note to say "via <option>--git-pbuilder</option> or > <option>--git-qemubuilder</option>" since it works under either > option. I'd also suggest adding the note to --git-arch, --git-dist, > and --git-pbuilder-autoconf since these options are all in the same > conditional and don't appear to be used elsewhere.
The other option already had some mention of git-pbuilder but didn't mention qemubuilder so I made this more explicit like in --git-pbuilder-options. Thanks for your comment. Cheers, -- Guido
